* [PATCH -mm2] net: Fix compiler-error on atyfb_base.c when !CONFIG_PCI
@ 2005-11-22 2:21 Richard Knutsson
2005-11-22 2:50 ` Al Viro
2005-11-22 3:29 ` Richard Knutsson
0 siblings, 2 replies; 3+ messages in thread
From: Richard Knutsson @ 2005-11-22 2:21 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Richard Knutsson
From: Richard Knutsson <ricknu-0@student.ltu.se>
Fix compiler-error on atyfb_base.c when CONFIG_PCI not set.
Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
---
atyfb_base.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
diff -Narup a/drivers/net/dgrs.c b/drivers/net/dgrs.c
--- a/drivers/video/aty/atyfb_base.c 2005-11-22 01:41:54.000000000 +0100
+++ b/drivers/video/aty/atyfb_base.c 2005-11-22 01:42:15.000000000 +0100
@@ -3606,7 +3606,8 @@ static struct pci_driver atyfb_driver =
.resume = atyfb_pci_resume,
#endif /* CONFIG_PM */
};
-
+#else
+static struct pci_driver atyfb_driver = {};
#endif /* CONFIG_PCI */
#ifndef MODULE
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -mm2] net: Fix compiler-error on atyfb_base.c when !CONFIG_PCI
2005-11-22 2:21 [PATCH -mm2] net: Fix compiler-error on atyfb_base.c when !CONFIG_PCI Richard Knutsson
@ 2005-11-22 2:50 ` Al Viro
2005-11-22 3:29 ` Richard Knutsson
1 sibling, 0 replies; 3+ messages in thread
From: Al Viro @ 2005-11-22 2:50 UTC (permalink / raw)
To: Richard Knutsson; +Cc: Andrew Morton, linux-kernel
On Tue, Nov 22, 2005 at 03:21:42AM +0100, Richard Knutsson wrote:
> From: Richard Knutsson <ricknu-0@student.ltu.se>
>
> Fix compiler-error on atyfb_base.c when CONFIG_PCI not set.
NAK. Please, don't introduce bogus objects.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -mm2] net: Fix compiler-error on atyfb_base.c when !CONFIG_PCI
2005-11-22 2:21 [PATCH -mm2] net: Fix compiler-error on atyfb_base.c when !CONFIG_PCI Richard Knutsson
2005-11-22 2:50 ` Al Viro
@ 2005-11-22 3:29 ` Richard Knutsson
1 sibling, 0 replies; 3+ messages in thread
From: Richard Knutsson @ 2005-11-22 3:29 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
Richard Knutsson wrote:
>diff -Narup a/drivers/net/dgrs.c b/drivers/net/dgrs.c
>
>
Should of course be:
diff -Narup a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c
Lacy cut 'n' paste, sorry about that.
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-11-22 3:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-22 2:21 [PATCH -mm2] net: Fix compiler-error on atyfb_base.c when !CONFIG_PCI Richard Knutsson
2005-11-22 2:50 ` Al Viro
2005-11-22 3:29 ` Richard Knutsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox