Re: [PATCH 2/5] Ensure NO_IRQ is appropriately defined on all architectures

Matthew Wilcox
2005-11-22T16:43:52Z

On Tue, Nov 22, 2005 at 02:27:55PM +0000, Christoph Hellwig wrote:
> On Tue, Nov 22, 2005 at 12:19:06AM -0500, Matthew Wilcox wrote:
> > Add a default definition of NO_IRQ to <linux/hardirq.h> and make the
> > definition in <asm/hardirq.h> uniform across all architectures which
> > define it.
>
> Please put the definition into <asm/irq.h> and <linux/interrupt.h>,
> hardirq.h is rather misnamed and about the internal irq/softirq/preempt
> mask mechanisms.

Either you're wrong or I'm confused. I don't see the include path which
necessarily drags asm/irq.h in from linux/interrupt.h. There's a
linux/interrupt.h -> linux/hardirq.h -> asm/hardirq.h path, but not all
asm/hardirq.h files drag in asm/irq.h. Look at sparc64 or alpha for
examples of that.

Personally, I'd like to see asm/hardirq.h go away and move all its
contents into asm/irq.h. And I'd like to see asm/irq.h included
explicitly from linux/interrupt.h. And I'd like to see drivers stop
including asm/irq.h.

While I'm dreaming, I'd like a pony.