From: Greg KH <gregkh@suse.de>
To: Luiz Fernando Capitulino <lcapitulino@mandriva.com.br>
Cc: linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net, akpm@osdl.org,
ehabkost@mandriva.com
Subject: Re: [PATCH 2/2] - usbserial: race-condition fix.
Date: Tue, 22 Nov 2005 14:13:53 -0800 [thread overview]
Message-ID: <20051122221353.GA10311@suse.de> (raw)
In-Reply-To: <20051122195926.18c3221c.lcapitulino@mandriva.com.br>
On Tue, Nov 22, 2005 at 07:59:26PM -0200, Luiz Fernando Capitulino wrote:
> @@ -60,6 +61,7 @@ struct usb_serial_port {
> struct usb_serial * serial;
> struct tty_struct * tty;
> spinlock_t lock;
> + struct semaphore sem;
You forgot to document what this semaphore is used for.
Hm, can we just use the spinlock already present in the port structure
for this? Well, drop the spinlock and use the semaphore? Yeah, that
means grabbing a semaphore for ever write for some devices, but USB data
rates are slow enough it wouldn't matter :)
thanks,
greg k-h
next prev parent reply other threads:[~2005-11-22 22:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-22 21:59 [PATCH 2/2] - usbserial: race-condition fix Luiz Fernando Capitulino
2005-11-22 22:13 ` Greg KH [this message]
2005-11-23 11:36 ` Luiz Fernando Capitulino
2005-11-23 11:56 ` Eduardo Pereira Habkost
2005-11-23 12:07 ` Luiz Fernando Capitulino
2005-11-23 20:03 ` Greg KH
2005-11-23 18:00 ` Greg KH
2005-11-23 17:46 ` [RESEND " Luiz Fernando Capitulino
2005-11-23 18:01 ` Greg KH
2005-11-23 19:02 ` Luiz Fernando Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051122221353.GA10311@suse.de \
--to=gregkh@suse.de \
--cc=akpm@osdl.org \
--cc=ehabkost@mandriva.com \
--cc=lcapitulino@mandriva.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox