public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Stezenbach <js@linuxtv.org>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Neil Brown <neilb@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: pivot_root broken in 2.6.15-rc1-mm2
Date: Wed, 23 Nov 2005 03:38:25 +0100	[thread overview]
Message-ID: <20051123023825.GA11869@linuxtv.org> (raw)
In-Reply-To: <20051123021545.GP27946@ftp.linux.org.uk>

On Wed, Nov 23, 2005 at 02:15:45AM +0000, Al Viro wrote:
> On Wed, Nov 23, 2005 at 01:07:28PM +1100, Neil Brown wrote:
> > After putting in copious tracing printk, the offending test is:
> > 
> > 	if (user_nd.mnt->mnt_parent == user_nd.mnt)
> > 		goto out2; /* not attached */
> > 
> > If I remove this, it works (or seems to).
> > Presumably the initial root file system is 'not attached'.  But that
> > shouldn't be a problem, should it?
> 
> Initial root is root and will remain root, period.
> 
> > Could this be related to the new shared mounts stuff???
> 
> No.  And no, it's not going to change - any memory you win on killing
> initramfs is not going to be worth the extra code needed to special-case
> it.
> 
> pivot_root() does work in chroot jail (including the one we get after
> chrooting to "final" root), but that's all it does.

Just want to add that some nice person wrote
Documentation/filesystems/ramfs-rootfs-initramfs.txt.

http://lwn.net/Articles/156098/
http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;h=b3404a0325967de5fdce4a29e879258075ede500;hb=4b4a27dff4e2d4cc2eac1cde31aede834a966a48;f=Documentation/filesystems/ramfs-rootfs-initramfs.txt

HTH,
Johannes

  reply	other threads:[~2005-11-23  2:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-23  2:07 pivot_root broken in 2.6.15-rc1-mm2 Neil Brown
2005-11-23  2:15 ` Al Viro
2005-11-23  2:38   ` Johannes Stezenbach [this message]
2005-11-23  3:01   ` Neil Brown
2005-11-23 12:02     ` Rob Landley
2005-11-25 11:52       ` Nix
2005-11-25 13:16         ` Rob Landley
2005-11-25 15:32           ` Nix
2005-11-23 11:43 ` Rob Landley
2005-11-24  5:09   ` Neil Brown
2005-11-24  5:54     ` [PATCH] " Rob Landley
2005-11-25 11:53   ` Nix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051123023825.GA11869@linuxtv.org \
    --to=js@linuxtv.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox