From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Kumar Gala <galak@gate.crashing.org>
Cc: Greg KH <greg@kroah.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: overlapping resources for platform devices?
Date: Wed, 23 Nov 2005 22:30:57 +0000 [thread overview]
Message-ID: <20051123223057.GO15449@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.44.0511231245350.4255-100000@gate.crashing.org>
On Wed, Nov 23, 2005 at 12:48:55PM -0600, Kumar Gala wrote:
> On Wed, 23 Nov 2005, Russell King wrote:
>
> > On Wed, Nov 23, 2005 at 12:57:40AM -0600, Kumar Gala wrote:
> > > Any update?
> >
> > It should be okay, but I'll step back from saying "safe" because
> > I don't particularly like the insert_resource() concept.
>
> Ok. Not sure how to take that. Would you prefer we work around this some
> other way? or your willing to take a patch but just hesitant about it
> breaking something?
PCI survived this change, so I've no doubt that platform devices will
survive. I just don't like it on a personal level because I worry
about the possibility of inappropriately inserting a resource above
some other resource.
Theoretically, if you have two platform devices which are mutually
exclusive, but use exactly the same resource range, with the existing
system only one will succeed. My understanding of insert_resource
indicates that both will succeed, and you'll end up with one below
the other.
That's not too much of a problem as long as the drivers also request
the resources before using them.
But that's theory. I don't know of any situation today where this
is presently true, or would be.
In the end, we can't have your behaviour without also having the
_possibility_ of this problem. So let's have your behaviour as
it fixes a real problem you're seeing.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
prev parent reply other threads:[~2005-11-23 22:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-15 23:31 overlapping resources for platform devices? Kumar Gala
2005-11-16 6:41 ` Greg KH
2005-11-17 15:36 ` Kumar Gala
2005-11-17 15:49 ` Russell King
2005-11-23 6:57 ` Kumar Gala
2005-11-23 11:52 ` Russell King
2005-11-23 18:48 ` Kumar Gala
2005-11-23 22:30 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051123223057.GO15449@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=galak@gate.crashing.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox