public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS
Date: Wed, 23 Nov 2005 23:34:38 +0100	[thread overview]
Message-ID: <20051123223438.GY3963@stusta.de> (raw)

Currently, using an undeclared function gives a compile warning, but it 
can lead to a nasty runtime error if the prototype of the function is 
different from what gcc guessed.

With -Werror-implicit-function-declaration, we are getting an immediate 
compile error instead.

There will be some compile errors in cases where compilation previously
worked because the undefined function wasn't called due to gcc dead code
elimination, but in these cases a proper fix doesnt harm.


This patch also removes some unneeded spaces between two tabs in the 
following line and a now no longer required
-Werror-implicit-function-declaration from
drivers/input/joystick/iforce/Makefile.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.13-rc3-mm3-full/Makefile.old	2005-07-30 13:55:32.000000000 +0200
+++ linux-2.6.13-rc3-mm3-full/Makefile	2005-07-30 13:55:56.000000000 +0200
@@ -351,7 +351,8 @@
 CPPFLAGS        := -D__KERNEL__ $(LINUXINCLUDE)
 
 CFLAGS 		:= -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
-	  	   -fno-strict-aliasing -fno-common \
+		   -Werror-implicit-function-declaration \
+		   -fno-strict-aliasing -fno-common \
 		   -ffreestanding
 AFLAGS		:= -D__ASSEMBLY__
 

--- linux-2.6.15-rc2-mm1-full/drivers/input/joystick/iforce/Makefile.old	2005-11-23 14:22:11.000000000 +0100
+++ linux-2.6.15-rc2-mm1-full/drivers/input/joystick/iforce/Makefile	2005-11-23 14:22:17.000000000 +0100
@@ -17,4 +17,3 @@
 	iforce-objs += iforce-usb.o
 endif
 
-EXTRA_CFLAGS = -Werror-implicit-function-declaration

             reply	other threads:[~2005-11-23 22:34 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-23 22:34 Adrian Bunk [this message]
2005-11-23 23:09 ` [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS Andrew Morton
2005-11-23 23:38   ` Adrian Bunk
2005-11-23 23:50     ` Andrew Morton
2005-11-24  0:13       ` Adrian Bunk
  -- strict thread matches above, loose matches on Subject: below --
2006-07-07 17:10 Luck, Tony
2006-07-06 16:37 Adrian Bunk
2006-07-06 18:05 ` Jesper Juhl
2006-07-06 18:20 ` Dave Jones
2006-07-07  3:36 ` Sam Ravnborg
2006-07-07  5:02   ` Valdis.Kletnieks
2006-07-07  6:42     ` Sam Ravnborg
2006-07-07  7:49       ` Adrian Bunk
2006-07-07  7:53     ` Milton Miller
2006-07-07  7:18   ` Adrian Bunk
2006-07-07  7:49   ` Heiko Carstens
2006-07-07  9:33     ` Sam Ravnborg
2006-06-28 16:54 Adrian Bunk
2005-11-07 20:03 Adrian Bunk
2005-11-10 12:28 ` Andrew Morton
2005-11-11  2:12   ` Adrian Bunk
2005-11-11  2:24     ` Andrew Morton
2005-11-11  3:45       ` Randy.Dunlap
2005-11-11 20:18       ` Adrian Bunk
2005-11-11 20:20         ` Adrian Bunk
2005-11-11 20:36           ` Adrian Bunk
2005-11-11 21:24         ` Andrew Morton
2005-11-11 23:34           ` Sam Ravnborg
2005-11-12  0:33         ` Adrian Bunk
2005-08-30 14:54 Adrian Bunk
2005-08-30 16:18 ` Olaf Hering
2005-08-30 16:29   ` Adrian Bunk
2005-08-30 16:38     ` Olaf Hering
2005-08-30 16:48       ` Adrian Bunk
2005-07-30 16:52 Adrian Bunk
2005-07-30 18:08 ` Andrew Morton
2005-07-30 19:44   ` Adrian Bunk
2005-07-30 18:52 ` Sam Ravnborg
2005-07-30 18:59   ` Christoph Hellwig
2005-07-30 19:40     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051123223438.GY3963@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox