Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

Adrian Bunk
2005-08-30T16:29:46Z

On Tue, Aug 30, 2005 at 06:18:14PM +0200, Olaf Hering wrote:
> On Tue, Aug 30, Adrian Bunk wrote:
>
> > Currently, using an undeclared function gives a compile warning, but it
> > can lead to a link or even a runtime error.
> >
> > With -Werror-implicit-function-declaration, we are getting an immediate
> > compile error instead.
>
> You have to fix CONFIG_SWAP=n as well.
>
> http://lkml.org/lkml/2005/8/6/72

I don't see any such warning in the 2.6.13 sparc build at Jan's
crosscompile page [1], and all my patch does is to turn a warning into
an error.

If a #define is using it before the header with the prototype get's
#include'd that's no problem as long as the prototype is available when
the #define is _used_.

I'm not saying that there aren't cases this patch will break (and my
patch shouldn't go into 2.6.14), but your example doesn't seem to cause
problems.

cu
Adrian

[1] http://l4x.org/k/?d=6676

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed