Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

Adrian Bunk
2005-11-11T20:36:06Z

On Fri, Nov 11, 2005 at 09:20:05PM +0100, Adrian Bunk wrote:
> On Fri, Nov 11, 2005 at 09:18:49PM +0100, Adrian Bunk wrote:
> >...
> > But in this case -Werror-implicit-function-declaration doesn't create
> > new compile errors, it only moves compile errors from compile time to
> > link or depmod time - which is IMHO not a bad change.
> >
> > If you really want to keep the status quo, you can still steal the
> > following from sparc64:
> > extern unsigned long virt_to_bus_not_defined_use_pci_map(volatile void *addr);
> > #define virt_to_bus virt_to_bus_not_defined_use_pci_map
> > extern unsigned long bus_to_virt_not_defined_use_pci_map(volatile void *addr);
> > #define bus_to_virt bus_to_virt_not_defined_use_pci_map
> >
> > Would a patch to mark the ISA legacy functions as __deprecated be OK?
> >...
>
> Sorry, this were two separate thoughts:
>
> Would a patch to mark both virt_to_bus/bus_to_virt and the ISA legacy
> functions (that cause similar problems) as __deprecated be OK?

Rethinking about this:
The ISA legacy functions were declared obsolete five years ago.
Since there are not many drivers using them, we could simply mark the
drivers still using them as BROKEN.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed