Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

Milton Miller
2006-07-07T07:55:31Z

> On Fri, 07 Jul 2006 05:36:30 +0200, Sam Ravnborg said:
> > On Thu, Jul 06, 2006 at 06:37:28PM +0200, Adrian Bunk wrote:
> > > With -Werror-implicit-function-declaration we are getting an immediate
> > > compile error instead.
> > This patch broke (-rc1):
> ...
> > I did not try other architectures. We need to fix the allnoconfig cases
> > at least for the popular architectures before applying this patch
> > otherwise it will create too much trouble/noise.

Sam wrote on Fri Jul 07 2006 - 02:40:55 EST::
> The error messages follows (for ia64, sparc and ppc64).
> make -C /home/sam/kernel/kbuild.git O=/home/sam/kernel/oppc64
> Using /home/sam/kernel/kbuild.git as source for kernel
> GEN /home/sam/kernel/oppc64/Makefile
> CHK include/linux/version.h
> CHK include/linux/utsrelease.h
> SYMLINK include/asm -> include/asm-powerpc
> CHK include/linux/compile.h
> CC arch/powerpc/mm/tlb_32.o
> In file included from include2/asm/tlb.h:52,
> from /home/sam/kernel/kbuild.git/arch/powerpc/mm/tlb_32.c:31:
> /home/sam/kernel/kbuild.git/include/asm-generic/tlb.h: In function `tlb_flush_mmu':
> /home/sam/kernel/kbuild.git/include/asm-generic/tlb.h:76: error: implicit declaration of function `release_pages'
> /home/sam/kernel/kbuild.git/include/asm-generic/tlb.h: In function `tlb_remove_page':
> /home/sam/kernel/kbuild.git/include/asm-generic/tlb.h:105: error: implicit declaration of function `page_cache_release'
> make[3]: *** [arch/powerpc/mm/tlb_32.o] Error 1
> make[2]: *** [arch/powerpc/mm] Error 2
> make[1]: *** [_all] Error 2
> make: *** [all] Error 2
>

That is cross architcture (asm-generic) CONFIG_SWAP=n

http://marc.theaimsgroup.com/?l=linux-kernel&m=106674447120368&w=2

My vote is if the file needs it in an inline, add the include. Otherwise
split the definition to a new file..

miton