Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

Andrew Morton
2005-11-23T23:51:21Z

Adrian Bunk <bunk@stusta.de> wrote:
>
> On Wed, Nov 23, 2005 at 03:09:05PM -0800, Andrew Morton wrote:
> > Adrian Bunk <bunk@stusta.de> wrote:
> > >
> > > Currently, using an undeclared function gives a compile warning, but it
> > > can lead to a nasty runtime error if the prototype of the function is
> > > different from what gcc guessed.
> > >
> > > With -Werror-implicit-function-declaration, we are getting an immediate
> > > compile error instead.
> >
> > Where "we" == "me". This patch means I get to fix all the errors which I
> > encounter. No fair. This should be the last patch, not the first.
>
> Is it my fault that you applied neither Al Viro's patches to remove the
> usages of the ISA legacy functions

Never saw them.

> nor my patch to mark
> virt_to_bus/bus_to_virt as __deprecated on i386?

That won't make powerpc compile.

Plus there are various other unfixed functions around the tree with various
.configs.

It took about four releases to teach people that the jsm driver won't
compile. I don't want to go adding things to -mm which break it in this
way - that causes us to lose testers.

The patch is a good one, but it should come last.