Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

Sam Ravnborg
2005-07-30T19:38:54Z

On Sat, Jul 30, 2005 at 07:59:11PM +0100, Christoph Hellwig wrote:
> On Sat, Jul 30, 2005 at 08:52:26PM +0200, Sam Ravnborg wrote:
> > Please - use tabs for indention, not for alignment.
> > The below would look rather messy with tabs=4.
> > Almost everywhere tabs are used in Makefiles it is plina wrong.
> > Tabs are brillient for indention but you cannot just assume 8 spaces = a
> > tab. Not even at the beginning of the line.
>
> as far as working on the kernel, yes you can assume that.

A bad assumption in several cases.
But if one never ever never use tabs != 8 they do not see the horror,
and so they probarly do not care.

For the Makefiles you will continue to see spaces used for alignmnet.

PS. Last word on this issue - I do not wan't to spend my linux time on a
sapce / versus tabs flamefest.

Sam