Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

Andrew Morton
2005-07-30T18:16:12Z

Adrian Bunk <bunk@stusta.de> wrote:
>
> Currently, using an undeclared function gives a compile warning, but it
> can lead to a link or even a runtime error.
>
> With -Werror-implicit-function-declaration, we are getting an immediate
> compile error instead.
>
> This patch also removes some unneeded spaces between two tabs in the
> following line.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.13-rc3-mm3-full/Makefile.old 2005-07-30 13:55:32.000000000 +0200
> +++ linux-2.6.13-rc3-mm3-full/Makefile 2005-07-30 13:55:56.000000000 +0200
> @@ -351,7 +351,8 @@
> CPPFLAGS := -D__KERNEL__ $(LINUXINCLUDE)
>
> CFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
> - -fno-strict-aliasing -fno-common \
> + -Werror-implicit-function-declaration \
> + -fno-strict-aliasing -fno-common \
> -ffreestanding
> AFLAGS := -D__ASSEMBLY__
>

heh. Nice idea, but if I merge this I'll have tons of monkey work to do
to get ppc64, ia64 and others compiling :(

umm, so what to do? I'm inclined to just slam it in post-2.6.13 then take
a week off or something.