public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dinakar Guniguntala <dino@in.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org
Subject: More PI issues with -rt
Date: Fri, 25 Nov 2005 01:26:01 +0530	[thread overview]
Message-ID: <20051124195601.GA9098@in.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

Hi,

I found that PI boosted SCHED_OTHER tasks behave like they have
SCHED_FIFO policy, while PI boosted SCHED_RR tasks continue to
behave like they have SCHED_RR policy. This didn't seem right

Does something like the following patch make sense?

	-Dinakar



[-- Attachment #2: pi-fix.patch --]
[-- Type: text/plain, Size: 682 bytes --]

Index: linux-2.6.14/kernel/sched.c
===================================================================
--- linux-2.6.14.orig/kernel/sched.c	2005-11-25 01:24:06.000000000 +0530
+++ linux-2.6.14/kernel/sched.c	2005-11-25 01:24:26.000000000 +0530
@@ -2986,8 +2986,9 @@
 		 * On PREEMPT_RT, boosted tasks will also get into this
 		 * branch and wont get their timeslice decreased until
 		 * they have done their work.
+		 * Boosted SCHED_OTHER tasks round-robin as well
 		 */
-		if ((p->policy == SCHED_RR) && !--p->time_slice) {
+		if ((p->policy != SCHED_FIFO) && !--p->time_slice) {
 			p->time_slice = task_timeslice(p);
 			p->first_time_slice = 0;
 			set_tsk_need_resched(p);

             reply	other threads:[~2005-11-24 19:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-24 19:56 Dinakar Guniguntala [this message]
2005-12-07 19:34 ` More PI issues with -rt Dinakar Guniguntala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051124195601.GA9098@in.ibm.com \
    --to=dino@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox