From: Vivek Goyal <vgoyal@in.ibm.com>
To: Morton Andrew Morton <akpm@osdl.org>,
linux kernel mailing list <linux-kernel@vger.kernel.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Linus Torvalds <torvalds@osdl.org>
Subject: [PATCH] memorize where 8259 is connected fix
Date: Fri, 25 Nov 2005 09:23:18 +0530 [thread overview]
Message-ID: <20051125035318.GA3796@in.ibm.com> (raw)
o A minor fix to the patch which remembers the location of where i8259
is connected. Now counter i has been replaced by apic. counter i is having
some junk value which was leading to non-detection of i8259 connected to
IOAPIC.
Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
---
diff -puN arch/x86_64/kernel/io_apic.c~kexec-memorize-where-i8259-connected-fix arch/x86_64/kernel/io_apic.c
--- linux-2.6.15-rc2-mm1-1M/arch/x86_64/kernel/io_apic.c~kexec-memorize-where-i8259-connected-fix 2005-11-24 05:49:44.000000000 -0800
+++ linux-2.6.15-rc2-mm1-1M-root/arch/x86_64/kernel/io_apic.c 2005-11-24 05:50:22.000000000 -0800
@@ -1240,7 +1240,7 @@ static void __init enable_IO_APIC(void)
for(apic = 0; apic < nr_ioapics; apic++) {
int pin;
/* See if any of the pins is in ExtINT mode */
- for(pin = 0; pin < nr_ioapic_registers[i]; pin++) {
+ for(pin = 0; pin < nr_ioapic_registers[apic]; pin++) {
struct IO_APIC_route_entry entry;
spin_lock_irqsave(&ioapic_lock, flags);
*(((int *)&entry) + 0) = io_apic_read(apic, 0x10 + 2 * pin);
diff -puN arch/i386/kernel/io_apic.c~kexec-memorize-where-i8259-connected-fix arch/i386/kernel/io_apic.c
--- linux-2.6.15-rc2-mm1-1M/arch/i386/kernel/io_apic.c~kexec-memorize-where-i8259-connected-fix 2005-11-24 05:50:38.000000000 -0800
+++ linux-2.6.15-rc2-mm1-1M-root/arch/i386/kernel/io_apic.c 2005-11-24 05:50:55.000000000 -0800
@@ -1649,7 +1649,7 @@ static void __init enable_IO_APIC(void)
for(apic = 0; apic < nr_ioapics; apic++) {
int pin;
/* See if any of the pins is in ExtINT mode */
- for(pin = 0; pin < nr_ioapic_registers[i]; pin++) {
+ for(pin = 0; pin < nr_ioapic_registers[apic]; pin++) {
struct IO_APIC_route_entry entry;
spin_lock_irqsave(&ioapic_lock, flags);
*(((int *)&entry) + 0) = io_apic_read(apic, 0x10 + 2 * pin);
_
reply other threads:[~2005-11-25 3:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051125035318.GA3796@in.ibm.com \
--to=vgoyal@in.ibm.com \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox