From: Pavel Machek <pavel@ucw.cz>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: davej@codemonkey.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add basic PM support for Nvidia and ATI AGP bridges
Date: Fri, 25 Nov 2005 22:01:56 +0100 [thread overview]
Message-ID: <20051125210156.GA2272@elf.ucw.cz> (raw)
In-Reply-To: <20051124060030.GF28070@srcf.ucam.org>
Hi!
> I retrieved these from the swsusp2 patchset, but they seem to be
> independently useful. As a result, I'm not sure who the original author
> is - however, they seem to be pretty obvious.
>
> ## All lines beginning with `## DP:' are a description of the patch.
> ## DP: Description: Add suspend/resume support to ATI and Nvidia AGP bridges
> ## DP: Patch author: Unknown
> ## DP: Upstream status: Not submitted
>
> . $(dirname $0)/DPATCH
> @@ -507,6 +507,33 @@ static void __devexit agp_ati_remove(str
> agp_put_bridge(bridge);
> }
>
> +#ifdef CONFIG_PM
> +
> +static int agp_ati_suspend(struct pci_dev *pdev, pm_message_t state)
> +{
> + pci_save_state (pdev);
> + pci_set_power_state (pdev, 3);
PCI_D3hot, please.
> +static int agp_ati_resume(struct pci_dev *pdev)
> +{
> + struct agp_bridge_data *bridge = pci_get_drvdata(pdev);
> +
> + /* set power state 0 and restore PCI space */
> + pci_set_power_state (pdev, 0);
PCI_D0... ....and same in other two functions. Otherwise it looks ok.
Pavel
--
Thanks, Sharp!
prev parent reply other threads:[~2005-11-25 21:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-24 6:00 [PATCH] Add basic PM support for Nvidia and ATI AGP bridges Matthew Garrett
2005-11-24 11:33 ` Rolf Eike Beer
2005-11-25 21:01 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051125210156.GA2272@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox