public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.6 patch] drivers/message/i2o/pci.c: fix a NULL pointer dereference
@ 2005-11-20 23:08 Adrian Bunk
  0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2005-11-20 23:08 UTC (permalink / raw)
  To: markus.lidel; +Cc: linux-kernel, stable

The Coverity checker spotted this obvious NULL pointer dereference.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.15-rc1-mm2-full/drivers/message/i2o/pci.c.old	2005-11-20 21:50:45.000000000 +0100
+++ linux-2.6.15-rc1-mm2-full/drivers/message/i2o/pci.c	2005-11-20 21:51:08.000000000 +0100
@@ -421,8 +421,8 @@
 	i2o_pci_free(c);
 
       free_controller:
-	i2o_iop_free(c);
 	put_device(c->device.parent);
+	i2o_iop_free(c);
 
       disable:
 	pci_disable_device(pdev);


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [2.6 patch] drivers/message/i2o/pci.c: fix a NULL pointer dereference
@ 2005-11-23 22:34 Adrian Bunk
  0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2005-11-23 22:34 UTC (permalink / raw)
  To: Linus Torvalds, Andrew Morton; +Cc: markus.lidel, linux-kernel

The Coverity checker spotted this obvious NULL pointer dereference.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

This patch was already sent on:
- 21 Nov 2005

--- linux-2.6.15-rc1-mm2-full/drivers/message/i2o/pci.c.old	2005-11-20 21:50:45.000000000 +0100
+++ linux-2.6.15-rc1-mm2-full/drivers/message/i2o/pci.c	2005-11-20 21:51:08.000000000 +0100
@@ -421,8 +421,8 @@
 	i2o_pci_free(c);
 
       free_controller:
-	i2o_iop_free(c);
 	put_device(c->device.parent);
+	i2o_iop_free(c);
 
       disable:
 	pci_disable_device(pdev);


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [2.6 patch] drivers/message/i2o/pci.c: fix a NULL pointer dereference
@ 2005-11-26 23:37 Adrian Bunk
  2005-11-27 16:32 ` Markus Lidel
  0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2005-11-26 23:37 UTC (permalink / raw)
  To: Linus Torvalds, Andrew Morton; +Cc: markus.lidel, linux-kernel

The Coverity checker spotted this obvious NULL pointer dereference.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

This patch was already sent on:
- 23 Nov 2005
- 21 Nov 2005

--- linux-2.6.15-rc1-mm2-full/drivers/message/i2o/pci.c.old	2005-11-20 21:50:45.000000000 +0100
+++ linux-2.6.15-rc1-mm2-full/drivers/message/i2o/pci.c	2005-11-20 21:51:08.000000000 +0100
@@ -421,8 +421,8 @@
 	i2o_pci_free(c);
 
       free_controller:
-	i2o_iop_free(c);
 	put_device(c->device.parent);
+	i2o_iop_free(c);
 
       disable:
 	pci_disable_device(pdev);


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [2.6 patch] drivers/message/i2o/pci.c: fix a NULL pointer dereference
  2005-11-26 23:37 [2.6 patch] drivers/message/i2o/pci.c: fix a NULL pointer dereference Adrian Bunk
@ 2005-11-27 16:32 ` Markus Lidel
  0 siblings, 0 replies; 4+ messages in thread
From: Markus Lidel @ 2005-11-27 16:32 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Linus Torvalds, Andrew Morton, linux-kernel

Hello,

Adrian Bunk wrote:
> The Coverity checker spotted this obvious NULL pointer dereference.
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Signed-off-by: Markus Lidel <Markus.Lidel@shadowconnect.com

> This patch was already sent on:
> - 23 Nov 2005
> - 21 Nov 2005

Sorry, didn't know i have to answer to it. Next time i will respond earlier.

Thank you very much for this patch!

> --- linux-2.6.15-rc1-mm2-full/drivers/message/i2o/pci.c.old	2005-11-20 21:50:45.000000000 +0100
> +++ linux-2.6.15-rc1-mm2-full/drivers/message/i2o/pci.c	2005-11-20 21:51:08.000000000 +0100
> @@ -421,8 +421,8 @@
>  	i2o_pci_free(c);
>  
>        free_controller:
> -	i2o_iop_free(c);
>  	put_device(c->device.parent);
> +	i2o_iop_free(c);
>  
>        disable:
>  	pci_disable_device(pdev);

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2005-11-27 16:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-26 23:37 [2.6 patch] drivers/message/i2o/pci.c: fix a NULL pointer dereference Adrian Bunk
2005-11-27 16:32 ` Markus Lidel
  -- strict thread matches above, loose matches on Subject: below --
2005-11-23 22:34 Adrian Bunk
2005-11-20 23:08 Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox