From: Andi Kleen <ak@suse.de>
To: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@suse.de>,
Dave Jones <davej@redhat.com>, cpufreq <cpufreq@www.linux.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] CPU frequency display in /proc/cpuinfo
Date: Fri, 2 Dec 2005 19:19:27 +0100 [thread overview]
Message-ID: <20051202181927.GD9766@wotan.suse.de> (raw)
In-Reply-To: <20051202101331.A2723@unix-os.sc.intel.com>
On Fri, Dec 02, 2005 at 10:13:31AM -0800, Pallipadi, Venkatesh wrote:
> On x86_64:
> There is one single variable cpu_khz that gets written by all the CPUs. So,
> the frequency set by last CPU will be seen on /proc/cpuinfo of all the
> CPUs in the system. What you see also depends on whether you have constant_tsc
> capable CPU or not.
x86-64 part looks good. Thanks.
> /* query the current CPU frequency (in kHz). If zero, cpufreq couldn't detect it */
> unsigned int cpufreq_get(unsigned int cpu);
>
> +/* query the last known CPU freq (in kHz). If zero, cpufreq couldn't detect it */
> +#ifdef CONFIG_CPU_FREQ
> +unsigned int cpufreq_quick_get(unsigned int cpu);
> +#else
> +unsigned int cpufreq_quick_get(unsigned int cpu)
> +{
> + return 0;
> +}
> +#endif
Shouldn't this be a static inline?
-Andi
next prev parent reply other threads:[~2005-12-02 18:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-02 18:13 [PATCH] CPU frequency display in /proc/cpuinfo Venkatesh Pallipadi
2005-12-02 18:19 ` Andi Kleen [this message]
2005-12-02 18:43 ` Venkatesh Pallipadi
2005-12-04 16:43 ` Dominik Brodowski
2005-12-04 18:32 ` Andi Kleen
2005-12-04 19:49 ` Lee Revell
2005-12-04 20:13 ` Andi Kleen
2005-12-04 21:01 ` Horst von Brand
2005-12-05 1:16 ` Dave Jones
2005-12-05 13:02 ` Erik Mouw
2005-12-05 17:25 ` Dave Jones
2005-12-05 17:27 ` Lee Revell
2005-12-06 11:13 ` Erik Mouw
2005-12-06 16:56 ` Dave Jones
2005-12-06 17:35 ` Erik Mouw
2005-12-05 15:32 ` Lee Revell
2005-12-05 18:36 ` Andi Kleen
2005-12-05 15:59 ` Mark Lord
2005-12-05 17:26 ` Dave Jones
2005-12-05 16:29 ` Avi Kivity
2005-12-05 16:46 ` linux-os (Dick Johnson)
2005-12-05 17:27 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051202181927.GD9766@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=cpufreq@www.linux.org.uk \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox