From: Jean Delvare <khali@linux-fr.org>
To: Linus Torvalds <torvards@osdl.org>,
"Mauro Carvalho Chehab" <mchehab@brturbo.com.br>,
LKML <linux-kernel@vger.kernel.org>
Cc: LM Sensors <lm-sensors@lm-sensors.org>,
Andrew Morton <akpm@osdl.org>, Greg KH <gregkh@suse.de>
Subject: Incorrect v4l patch in 2.6.15-rc4-git1
Date: Fri, 2 Dec 2005 19:28:14 +0100 [thread overview]
Message-ID: <20051202192814.282fc10c.khali@linux-fr.org> (raw)
Hi Linus,
Please revert this commit:
author Mauro Carvalho Chehab <mchehab@brturbo.com.br>
Thu, 1 Dec 2005 08:51:35 +0000 (00:51 -0800)
committer Linus Torvalds <torvalds@g5.osdl.org>
Thu, 1 Dec 2005 23:48:57 +0000 (15:48 -0800)
commit 769e24382dd47434dfda681f360868c4acd8b6e2
tree 1be728dd2f1a7f523e3de5f3f39b97a4b9905dbe
parent 6f502b8a7858ecfa7d2a0762f7663b8b3d0808fc
[PATCH] V4L: Some funcions now static and I2C hw code for IR
- Some funcions are now declared as static
- Added a I2C code for InfraRed.
Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
I objected against this patch here :
http://lkml.org/lkml/2005/12/1/196
I would also seriously question the benefit of merging that kind of
patch at the -rc4 stage, even if it wasn't incorrect. It's not fixing
any actual problem, I can't see how it was supposed to belong there.
Thanks,
--
Jean Delvare
next reply other threads:[~2005-12-02 18:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-02 18:28 Jean Delvare [this message]
2005-12-03 9:27 ` Incorrect v4l patch in 2.6.15-rc4-git1 Mauro Carvalho Chehab
2005-12-03 11:47 ` Jean Delvare
2005-12-03 18:56 ` Mauro Carvalho Chehab
2005-12-04 23:59 ` Johannes Stezenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051202192814.282fc10c.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=akpm@osdl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mchehab@brturbo.com.br \
--cc=torvards@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox