Re: Add tainting for proprietary helper modules.

[Dave Jones <davej@redhat.com>]

On Fri, Dec 02, 2005 at 05:58:36PM -0700, Zan Lynx wrote:
 > On Fri, 2005-12-02 at 19:41 -0500, Dave Jones wrote:
 > > Kernels that have had Windows drivers loaded into them are undebuggable.
 > > I've wasted a number of hours chasing bugs filed in Fedora bugzilla
 > > only to find out much later that the user had used such 'helpers',
 > > and their problems were unreproducable without them loaded.
 > > 
 > > Acked-by: Arjan van de Ven <arjan@infradead.org>
 > > Signed-off-by: Dave Jones <davej@redhat.com>
 > > 
 > > --- linux-2.6.14/kernel/module.c~	2005-11-29 16:44:00.000000000 -0500
 > > +++ linux-2.6.14/kernel/module.c	2005-11-29 17:03:55.000000000 -0500
 > > @@ -1723,6 +1723,11 @@ static struct module *load_module(void _
 > >  	/* Set up license info based on the info section */
 > >  	set_license(mod, get_modinfo(sechdrs, infoindex, "license"));
 > >  
 > > +	if (strcmp(mod->name, "ndiswrapper") == 0)
 > > +		add_taint(TAINT_PROPRIETARY_MODULE);
 > > +	if (strcmp(mod->name, "driverloader") == 0)
 > > +		add_taint(TAINT_PROPRIETARY_MODULE);
 > > +
 > >  #ifdef CONFIG_MODULE_UNLOAD
 > >  	/* Set up MODINFO_ATTR fields */
 > >  	setup_modinfo(mod, sechdrs, infoindex);
 > 
 > ndiswrapper adds taint already, in load_ndis_driver().

That's good to hear.  Although I've definitly seen some
reports which have come through untainted. My guesses are
that the users were using an older ndiswrapper that didn't do this,
or they were using a < 2.6.10 kernel at the time
(for which ndiswrapper doesn't do this).

		Dave