From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andy Isaacson <adi@hexapodia.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][mm][Fix] swsusp: fix counting of highmem pages
Date: Sun, 4 Dec 2005 01:35:46 +0100 [thread overview]
Message-ID: <20051204003546.GF5198@elf.ucw.cz> (raw)
In-Reply-To: <200512040126.14048.rjw@sisk.pl>
Hi!
> > > }
> > > + if (n > 0)
> > > + n += (n * KMALLOC_SIZE + PAGE_SIZE - 1) / PAGE_SIZE + 1;
> > > return n;
> > > }
> >
> > Can't you just n += n/50 here? Playing with KMALLOC_SIZE knows way too
> > much about memory allocation details.
>
> I do the "n + n/50" later on, so I can just drop all of the above changes
> if they are too complicated.
Yes, that would be nice.
Pavel
--
Thanks, Sharp!
next prev parent reply other threads:[~2005-12-04 0:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-03 20:40 [PATCH][mm][Fix] swsusp: fix counting of highmem pages Rafael J. Wysocki
2005-12-03 21:40 ` Pavel Machek
2005-12-03 23:11 ` Rafael J. Wysocki
2005-12-03 23:50 ` Pavel Machek
2005-12-04 0:02 ` Rafael J. Wysocki
2005-12-04 0:10 ` Pavel Machek
2005-12-04 0:26 ` Rafael J. Wysocki
2005-12-04 0:35 ` Pavel Machek [this message]
2005-12-04 0:57 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051204003546.GF5198@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=adi@hexapodia.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox