* [PATCH] [MMC] Proper check of SCR error code
@ 2005-12-04 14:00 Pierre Ossman
2005-12-05 10:01 ` Russell King
0 siblings, 1 reply; 2+ messages in thread
From: Pierre Ossman @ 2005-12-04 14:00 UTC (permalink / raw)
To: rmk+lkml; +Cc: Pierre Ossman, linux-kernel
The routine reading the SCR wasn't paying proper attention to the error
codes returned from the driver.
Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
---
drivers/mmc/mmc.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index d336a1d..b586a83 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -932,8 +932,9 @@ static void mmc_read_scrs(struct mmc_hos
sg_init_one(&sg, (u8*)card->raw_scr, 8);
- err = mmc_wait_for_req(host, &mrq);
- if (err != MMC_ERR_NONE) {
+ mmc_wait_for_req(host, &mrq);
+
+ if (cmd.error != MMC_ERR_NONE || data.error != MMC_ERR_NONE) {
mmc_card_set_dead(card);
continue;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [MMC] Proper check of SCR error code
2005-12-04 14:00 [PATCH] [MMC] Proper check of SCR error code Pierre Ossman
@ 2005-12-05 10:01 ` Russell King
0 siblings, 0 replies; 2+ messages in thread
From: Russell King @ 2005-12-05 10:01 UTC (permalink / raw)
To: Pierre Ossman; +Cc: Pierre Ossman, linux-kernel
On Sun, Dec 04, 2005 at 03:00:19PM +0100, Pierre Ossman wrote:
> The routine reading the SCR wasn't paying proper attention to the error
> codes returned from the driver.
Applied, thanks Pierre.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-12-05 10:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-04 14:00 [PATCH] [MMC] Proper check of SCR error code Pierre Ossman
2005-12-05 10:01 ` Russell King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox