From: Dipankar Sarma <dipankar@in.ibm.com>
To: Srivatsa Vaddagiri <vatsa@in.ibm.com>
Cc: paulmck@us.ibm.com, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix bug in RCU torture test
Date: Mon, 5 Dec 2005 18:04:09 +0530 [thread overview]
Message-ID: <20051205123409.GD3936@in.ibm.com> (raw)
In-Reply-To: <20051205105849.GD2385@in.ibm.com>
On Mon, Dec 05, 2005 at 04:28:49PM +0530, Srivatsa Vaddagiri wrote:
> While doing some test of RCU torture module, I hit a OOPS in rcu_do_batch,
> which was trying to processes callback of a module that was just removed.
> This is because we weren't waiting long enough for all callbacks to fire.
>
> diff -puN kernel/rcutorture.c~rcutorture_fix kernel/rcutorture.c
> --- linux-2.6.15-rc5-mm1/kernel/rcutorture.c~rcutorture_fix 2005-12-05 15:33:06.000000000 +0530
> +++ linux-2.6.15-rc5-mm1-root/kernel/rcutorture.c 2005-12-05 15:33:17.000000000 +0530
> @@ -408,9 +408,8 @@ rcu_torture_cleanup(void)
> stats_task = NULL;
>
> /* Wait for all RCU callbacks to fire. */
> + rcu_barrier();
Andrew,
This patch is dependent on the rcu_barrier patch buried in reiser4
patchset. It makes sense to merge that patch without waiting
for reiser4 since rcutorture is already in mainline.
I will send an updated documentation patch describing why
and how modules using RCU should use rcu_barrier().
Thanks
Dipankar
next prev parent reply other threads:[~2005-12-05 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-05 10:58 [PATCH] Fix bug in RCU torture test Srivatsa Vaddagiri
2005-12-05 12:34 ` Dipankar Sarma [this message]
2005-12-05 13:56 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051205123409.GD3936@in.ibm.com \
--to=dipankar@in.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@us.ibm.com \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox