From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: linux-ide <linux-ide@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>, pavel <pavel@ucw.cz>,
Len Brown <len.brown@intel.com>, akpm <akpm@osdl.org>
Subject: Re: [RFC]add ACPI hooks for IDE suspend/resume
Date: Tue, 6 Dec 2005 22:20:02 +0000 [thread overview]
Message-ID: <20051206222001.GA14171@srcf.ucam.org> (raw)
In-Reply-To: <1133849404.3026.10.camel@sli10-mobl.sh.intel.com>
On Tue, Dec 06, 2005 at 02:10:04PM +0800, Shaohua Li wrote:
> TODO: invoking ATA commands.
>
> Though we didn't invoke ATA commands, this patch fixes the bug at
> http://bugzilla.kernel.org/show_bug.cgi?id=5604. And Matthew said this
> actually fixes a lot of systems in his test.
> I'm not familiar with IDE, so comments/suggestions are welcome.
Of the DSDTs I've looked at, most seem to provide taskfile commands
concerned about doing things like setting up drive security. I haven't
yet seen an IDE failure on resume when using this patch, so the _GTF
stuff doesn't seem terribly important. The reason for it not currently
being implemented is that the IDE queues haven't been restarted at the
point where this code is called, so there's no obvious way of submitting
them to the drive yet.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2005-12-06 22:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-06 6:10 [RFC]add ACPI hooks for IDE suspend/resume Shaohua Li
2005-12-06 22:20 ` Matthew Garrett [this message]
2005-12-06 22:50 ` Alan Cox
2005-12-07 8:17 ` Bartlomiej Zolnierkiewicz
2005-12-07 13:14 ` Matthew Garrett
2005-12-07 14:19 ` Bartlomiej Zolnierkiewicz
2005-12-07 14:26 ` Bartlomiej Zolnierkiewicz
2005-12-07 14:34 ` Matthew Garrett
2005-12-07 14:33 ` Matthew Garrett
2005-12-07 14:45 ` Bartlomiej Zolnierkiewicz
2005-12-07 14:58 ` Matthew Garrett
2005-12-07 15:44 ` Bartlomiej Zolnierkiewicz
2005-12-07 15:53 ` Matthew Garrett
2005-12-07 15:41 ` Alan Cox
2005-12-07 15:49 ` Bartlomiej Zolnierkiewicz
2005-12-07 1:22 ` Shaohua Li
2005-12-07 19:15 ` Bartlomiej Zolnierkiewicz
2005-12-07 22:35 ` Alan Cox
2005-12-07 22:42 ` Bartlomiej Zolnierkiewicz
2005-12-07 22:43 ` Pavel Machek
2005-12-07 22:48 ` Matthew Garrett
2005-12-07 0:11 ` Randy.Dunlap
2005-12-07 1:15 ` Shaohua Li
-- strict thread matches above, loose matches on Subject: below --
2005-12-07 21:58 Li, Shaohua
2005-12-07 23:19 Li, Shaohua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051206222001.GA14171@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox