Re: [discuss] Re: 2.6.15-rc5-mm1 (x86_64-hpet-overflow.patch breaks resume from disk)

Rafael J. Wysocki
2005-12-08T22:59:06Z

Hi,

On Thursday, 8 December 2005 23:47, Andi Kleen wrote:
> On Thu, Dec 08, 2005 at 09:43:52AM +0100, Jan Beulich wrote:
> > I don't know how resume normally handles the re-syncing of the wall
> > clock, but the problem here is obvious: do_timer runs a loop to
> > increment jiffies, which may require significant amounts of time
> > (depending how long the system was sleeping).
>
> It would be good if someone could submit a patch to fix
> this up properly. It indeed sounds wrong.

Well, timer_resume() does adjust jiffies and wall_jiffies.

The problem seems to be that vxtime.last and/or vxtime.last_tsc are not
adjusted by it which makes the timer interrupt handler unhappy (with the
hpet-overflow patch applied, that is).

Greetings,
Rafael

--
Beer is proof that God loves us and wants us to be happy - Benjamin Franklin