From: Dave Jones <davej@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: rmk@arm.linux.org.uk
Subject: Missing break in timedia serial setup.
Date: Tue, 6 Dec 2005 20:05:26 -0500 [thread overview]
Message-ID: <20051207010526.GA7258@redhat.com> (raw)
Spotted during code review by a Fedora user.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174967
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.14/drivers/serial/8250_pci.c~ 2005-12-06 20:01:17.000000000 -0500
+++ linux-2.6.14/drivers/serial/8250_pci.c 2005-12-06 20:01:51.000000000 -0500
@@ -517,6 +517,7 @@ pci_timedia_setup(struct serial_private
case 3:
offset = board->uart_offset;
bar = 1;
+ break;
case 4: /* BAR 2 */
case 5: /* BAR 3 */
case 6: /* BAR 4 */
next reply other threads:[~2005-12-07 1:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-07 1:05 Dave Jones [this message]
2005-12-07 9:34 ` Missing break in timedia serial setup Russell King
2005-12-07 16:58 ` Dave Jones
2005-12-07 17:05 ` Arjan van de Ven
2005-12-07 17:44 ` Dave Jones
2005-12-07 18:11 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051207010526.GA7258@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox