From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Dave Jones <davej@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: Missing break in timedia serial setup.
Date: Wed, 7 Dec 2005 09:34:31 +0000 [thread overview]
Message-ID: <20051207093431.GB32365@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20051207010526.GA7258@redhat.com>
On Tue, Dec 06, 2005 at 08:05:26PM -0500, Dave Jones wrote:
> Spotted during code review by a Fedora user.
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174967
Makes no difference.
switch (idx) {
case 3:
bar = 1;
case 4: /* BAR 2 */
case 5: /* BAR 3 */
case 6: /* BAR 4 */
case 7: /* BAR 5 */
bar = idx - 2;
If idx is 3, idx - 2 is 1. So the bar = 1 is actually redundant in
case 3.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-12-07 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-07 1:05 Missing break in timedia serial setup Dave Jones
2005-12-07 9:34 ` Russell King [this message]
2005-12-07 16:58 ` Dave Jones
2005-12-07 17:05 ` Arjan van de Ven
2005-12-07 17:44 ` Dave Jones
2005-12-07 18:11 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051207093431.GB32365@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox