From: Andrew Morton <akpm@osdl.org>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: linux-kernel@vger.kernel.org, lhms-devel@lists.sourceforge.net
Subject: Re: [PATCH] swap migration: Fix lru drain
Date: Wed, 7 Dec 2005 16:57:30 -0800 [thread overview]
Message-ID: <20051207165730.02dc591e.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.62.0512071635250.26288@schroedinger.engr.sgi.com>
Christoph Lameter <clameter@engr.sgi.com> wrote:
>
> +int schedule_on_each_cpu(void (*func) (void *info), void *info)
> +{
> + int cpu;
> + struct work_struct *work;
> +
> + work = kmalloc(NR_CPUS * sizeof(struct work_struct), GFP_KERNEL);
> +
> + if (!work)
> + return 0;
> + for_each_online_cpu(cpu) {
> + INIT_WORK(work + cpu, func, info);
> + __queue_work(per_cpu_ptr(keventd_wq->cpu_wq, cpu),
> + work + cpu);
> + }
> + flush_workqueue(keventd_wq);
> + kfree(work);
> + return 1;
> +}
I'll change this to return 0 on success, or -ENOMEM. Bit more
conventional, no?
next prev parent reply other threads:[~2005-12-08 0:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-07 21:55 [PATCH] swap migration: Fix lru drain Christoph Lameter
2005-12-07 23:27 ` Nick Piggin
2005-12-08 0:43 ` Christoph Lameter
2005-12-08 0:58 ` Andrew Morton
2005-12-08 0:59 ` Nick Piggin
2005-12-08 0:13 ` Andrew Morton
2005-12-08 0:41 ` Christoph Lameter
2005-12-08 0:57 ` Andrew Morton [this message]
2005-12-08 1:14 ` Christoph Lameter
2005-12-08 5:02 ` [Lhms-devel] " KAMEZAWA Hiroyuki
2005-12-08 8:36 ` KAMEZAWA Hiroyuki
2005-12-08 8:43 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051207165730.02dc591e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=clameter@engr.sgi.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox