From: Russell King <rmk+lkml@arm.linux.org.uk>
To: dtor_core@ameritech.net, Greg KH <greg@kroah.com>
Cc: Jean Delvare <khali@linux-fr.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Minor change to platform_device_register_simple prototype
Date: Wed, 7 Dec 2005 18:08:42 +0000 [thread overview]
Message-ID: <20051207180842.GG6793@flint.arm.linux.org.uk> (raw)
In-Reply-To: <d120d5000512070959q6a957009j654e298d6767a5da@mail.gmail.com>
On Wed, Dec 07, 2005 at 12:59:09PM -0500, Dmitry Torokhov wrote:
> On 12/7/05, Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> > On Monday 05 December 2005 15:27, Russell King wrote:
> > > On Mon, Dec 05, 2005 at 09:23:37PM +0100, Jean Delvare wrote:
> > > > The name parameter of platform_device_register_simple should be of
> > > > type const char * instead of char *, as we simply pass it to
> > > > platform_device_alloc, where it has type const char *.
> > > >
> > > > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > >
> > > Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > >
> > > However, I've been wondering whether we want to keep this "simple"
> > > interface around long-term given that we now have a more flexible
> > > platform device allocation interface - I don't particularly like
> > > having superfluous interfaces for folk to get confused with.
> >
> > Now that you made platform_device_alloc install default release
> > handler there is no need to have the _simple interface. I will
> > convert input devices (main users of _simple) to the new interface
> > and then we can get rid of it.
> >
>
> I have started moving drivers from the "_simple" interface and I found
> that I'm missing platform_device_del that would complement
> platform_device_add. Would you object to having such a function, like
> we do for other sysfs objects? With it one can write somthing like
> this:
Greg and myself discussed that, and we decided that it was adding
unnecessary complexity to the interface. Maybe Greg's view has
changed?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-12-07 18:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-05 20:23 [PATCH] Minor change to platform_device_register_simple prototype Jean Delvare
2005-12-05 20:27 ` Russell King
2005-12-07 6:05 ` Dmitry Torokhov
2005-12-07 17:04 ` Greg KH
2005-12-08 21:21 ` Dmitry Torokhov
2005-12-08 21:37 ` Jean Delvare
2005-12-08 21:49 ` Dmitry Torokhov
2005-12-08 23:26 ` Russell King
2005-12-07 17:59 ` Dmitry Torokhov
2005-12-07 18:08 ` Russell King [this message]
2005-12-07 18:23 ` Dmitry Torokhov
2005-12-07 19:03 ` Russell King
2005-12-07 22:18 ` Dmitry Torokhov
2005-12-07 22:51 ` Greg KH
2005-12-07 22:59 ` Dmitry Torokhov
2005-12-07 23:06 ` Greg KH
2005-12-07 23:21 ` Russell King
2005-12-08 20:58 ` Jean Delvare
2005-12-08 21:06 ` Dmitry Torokhov
2005-12-08 23:17 ` Russell King
2005-12-08 20:52 ` Jean Delvare
2005-12-08 23:22 ` Russell King
2005-12-10 15:49 ` Jean Delvare
2005-12-11 19:44 ` Jean Delvare
2005-12-12 2:08 ` Dmitry Torokhov
2005-12-07 18:11 ` Dmitry Torokhov
2005-12-07 18:39 ` Randy.Dunlap
2005-12-07 19:05 ` Russell King
2005-12-07 6:50 ` Jean Delvare
2005-12-07 9:24 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051207180842.GG6793@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=dtor_core@ameritech.net \
--cc=greg@kroah.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox