public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Ben Gardner <gardner.ben@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
	lm-sensors <lm-sensors@lm-sensors.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] i386: CS5535 chip support - cpu
Date: Wed, 7 Dec 2005 19:12:34 +0100	[thread overview]
Message-ID: <20051207181234.GF31922@stusta.de> (raw)
In-Reply-To: <808c8e9d0512070931k607cd7a9g404d131ded8c014b@mail.gmail.com>

On Wed, Dec 07, 2005 at 11:31:09AM -0600, Ben Gardner wrote:
>...
> --- linux-2.6.14.orig/arch/i386/kernel/Makefile
> +++ linux-2.6.14/arch/i386/kernel/Makefile
> @@ -42,6 +42,14 @@ EXTRA_AFLAGS   := -traditional
>  
>  obj-$(CONFIG_SCx200)		+= scx200.o
>  
> +obj-$(CONFIG_CS5535)		+= cs5535.o
> +ifeq ($(CONFIG_CS5535_SMB), y)
> +EXTRA_CFLAGS += -DCS5535_SMB
> +endif
> +ifeq ($(CONFIG_CS5535_UART2), y)
> +EXTRA_CFLAGS += -DCS5535_UART2
> +endif
>...

Please use CONFIG_CS5535_{SMB,UART2} in cs5535.c instead of setting 
EXTRA_CFLAGS.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2005-12-07 18:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-07 17:31 [PATCH 1/3] i386: CS5535 chip support - cpu Ben Gardner
2005-12-07 18:12 ` Adrian Bunk [this message]
2005-12-07 19:31   ` Ben Gardner
  -- strict thread matches above, loose matches on Subject: below --
2005-12-07 19:42 Jordan Crouse
2005-12-09 15:01 ` Ben Gardner
2005-12-10  8:44 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051207181234.GF31922@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=gardner.ben@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox