From: Vivek Goyal <vgoyal@in.ibm.com>
To: Andi Kleen <ak@muc.de>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>,
Morton Andrew Morton <akpm@osdl.org>,
len.brown@intel.com
Subject: [PATCH] x86_64: acpi map table fix
Date: Thu, 8 Dec 2005 09:45:09 +0530 [thread overview]
Message-ID: <20051208041509.GA4841@in.ibm.com> (raw)
o Memory till end_pfn_map has been directly mapped. So all the memory
references to the last page (represented by end_pfn_map) should be
valid.
o I run into problem with kdump when I use memmap=exactmap option and also
pass memmap=X#Y to directly map acpi tables. ACPI initialization in second
kernel fails because some of the valid ACPI memory is not accessible.
o /proc/iomem shows ACPI tables at c7fcb940-c7fcf7ff : ACPI Tables. Here
end_pfn_map is set to c7fcf000. But c7fcf700 should also be a valid access.
Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
---
diff -puN arch/i386/kernel/acpi/boot.c~acpi-map-address-fix arch/i386/kernel/acpi/boot.c
--- linux-2.6.15-rc5-mm1-16M/arch/i386/kernel/acpi/boot.c~acpi-map-address-fix 2005-12-07 15:56:33.000000000 +0530
+++ linux-2.6.15-rc5-mm1-16M-root/arch/i386/kernel/acpi/boot.c 2005-12-07 15:58:04.000000000 +0530
@@ -108,7 +108,7 @@ char *__acpi_map_table(unsigned long phy
if (!phys_addr || !size)
return NULL;
- if (phys_addr < (end_pfn_map << PAGE_SHIFT))
+ if (phys_addr < ((end_pfn_map << PAGE_SHIFT) + PAGE_SIZE))
return __va(phys_addr);
return NULL;
_
next reply other threads:[~2005-12-08 4:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-08 4:15 Vivek Goyal [this message]
2005-12-08 8:37 ` [PATCH] x86_64: acpi map table fix Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051208041509.GA4841@in.ibm.com \
--to=vgoyal@in.ibm.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox