Re: [RFC][PATCH 2/3]i386,x86-64 Handle missing local APIC timer interrupts on C3 state

Andi Kleen
2005-12-09T18:07:41Z

Just a quick comment - didn't review the full patch.

> +#ifdef ARCH_APICTIMER_STOPS_ON_C3
> + if (c->x86_vendor == X86_VENDOR_INTEL) {
> + on_each_cpu(switch_APIC_timer_to_ipi,
> + &mask, 1, 1);
> + }
> +#endif

Better make it a runtime variable instead of an ifdef with a boot option.
I found at least one non Intel system so far with the same issue
(although it wasn't multi processor)

-Andi