From: Jens Axboe <axboe@suse.de>
To: Hugh Dickins <hugh@veritas.com>
Cc: "Michael S. Tsirkin" <mst@mellanox.co.il>,
Gleb Natapov <gleb@minantech.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Petr Vandrovec <vandrove@vc.cvut.cz>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Badari Pulavarty <pbadari@us.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: set_page_dirty vs set_page_dirty_lock
Date: Thu, 8 Dec 2005 20:54:34 +0100 [thread overview]
Message-ID: <20051208195433.GY26185@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0512081908530.11737@goblin.wat.veritas.com>
On Thu, Dec 08 2005, Hugh Dickins wrote:
> It can be very inconvenient (I don't know what to do for drivers/scsi/sg.c
> than set_page_dirty and hope for the best, since it cannot wait for a lock
> where it needs to). But I'm afraid you do have the very case where
> set_page_dirty_lock is appropriate.
See bio_set_pages_dirty() in fs/bio.c and the framework for handling
those (notably bio_dirty_fn()).
> Many would be pleased if we could manage without set_page_dirty_lock.
Indeed, would make life easier there as well..
--
Jens Axboe
next prev parent reply other threads:[~2005-12-08 19:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-08 19:09 set_page_dirty vs set_page_dirty_lock Michael S. Tsirkin
2005-12-08 19:19 ` Hugh Dickins
2005-12-08 19:29 ` Michael S. Tsirkin
2005-12-08 19:54 ` Jens Axboe [this message]
2005-12-08 21:56 ` Michael S. Tsirkin
2005-12-12 3:28 ` Nick Piggin
2005-12-12 6:35 ` Michael S. Tsirkin
2005-12-12 7:10 ` Nick Piggin
2005-12-12 8:14 ` Michael S. Tsirkin
2005-12-12 8:32 ` Nick Piggin
2005-12-12 8:55 ` Michael S. Tsirkin
2005-12-12 9:23 ` Nick Piggin
2005-12-12 9:59 ` Michael S. Tsirkin
2005-12-13 21:07 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051208195433.GY26185@suse.de \
--to=axboe@suse.de \
--cc=benh@kernel.crashing.org \
--cc=gleb@minantech.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@mellanox.co.il \
--cc=nickpiggin@yahoo.com.au \
--cc=pbadari@us.ibm.com \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox