From: Ravikiran G Thirumalai <kiran@scalex86.org>
To: Andi Kleen <ak@suse.de>
Cc: Christoph Lameter <clameter@engr.sgi.com>,
linux-kernel@vger.kernel.org, discuss@x86-64.org
Subject: Re: [discuss] Re: pcibus_to_node value when no pxm info is present for the pci bus
Date: Thu, 8 Dec 2005 12:21:38 -0800 [thread overview]
Message-ID: <20051208202138.GD3776@localhost.localdomain> (raw)
In-Reply-To: <20051208200440.GB15804@wotan.suse.de>
On Thu, Dec 08, 2005 at 09:04:40PM +0100, Andi Kleen wrote:
> > > > The question is, what should be the default pcibus_to_node if there is no
> > > > pxm info? Answer seems like -1 -- in which case dma_alloc_pages and e1000
> > > > driver has to be fixed.
> > >
> > > Why would they have to be fixed?
> >
> > alloc_pages_node (used by dma_alloc_pages) does not seem to do the check
> > though. I guess alloc_pages_node needs to be fixed then.
>
> Or just fix the caller. I will do that and change the default to
That was my thinking earlier too, but shouldn't we have uniformity in
behaviour between kmalloc_node and alloc_pages_node wrt nodeid handling?
IMHO it would be less confusing that way. alloc_pages_node is not that much
of a fastpath routine anyways...
Thanks,
Kiran
next prev parent reply other threads:[~2005-12-08 20:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-07 22:34 pcibus_to_node value when no pxm info is present for the pci bus Ravikiran G Thirumalai
2005-12-08 19:05 ` Christoph Lameter
2005-12-08 19:34 ` Ravikiran G Thirumalai
2005-12-08 20:04 ` [discuss] " Andi Kleen
2005-12-08 20:21 ` Ravikiran G Thirumalai [this message]
2005-12-08 20:26 ` Andi Kleen
2005-12-08 20:41 ` Christoph Lameter
2005-12-08 20:47 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051208202138.GD3776@localhost.localdomain \
--to=kiran@scalex86.org \
--cc=ak@suse.de \
--cc=clameter@engr.sgi.com \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox