From: Andi Kleen <ak@suse.de>
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@osdl.org, Christoph Hellwig <hch@infradead.org>,
linux-ia64@vger.kernel.org, steiner@sgi.com,
linux-kernel@vger.kernel.org, ak@suse.de,
Wu Fengguang <wfg@mail.ustc.edu.cn>
Subject: Re: [PATCH 3/3] Zone reclaim V3: Frequency of failed reclaim attempts
Date: Thu, 8 Dec 2005 21:52:41 +0100 [thread overview]
Message-ID: <20051208205241.GR11190@wotan.suse.de> (raw)
In-Reply-To: <20051208203717.30456.17434.sendpatchset@schroedinger.engr.sgi.com>
> + if (zone->last_unsuccessful_zone_reclaim == get_jiffies_64())
> + return 0;
and
>
> + unsigned long last_unsuccessful_zone_reclaim;
For long you don't need get_jiffies_64. On 32bit it would be 32bit
anyways and on 64bit even normal jiffies is 64bit. So normal
jiffies would be suffice.
But I suspect it would be better to just merge the proper patch
with the full accounting instead of this kludge.
-Andi
next prev parent reply other threads:[~2005-12-08 20:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-08 20:37 [PATCH 1/3] Zone reclaim V3: main patch Christoph Lameter
2005-12-08 20:37 ` [PATCH 2/3] Zone reclaim V3: Remove debris from old zone reclaim Christoph Lameter
2005-12-08 20:37 ` [PATCH 3/3] Zone reclaim V3: Frequency of failed reclaim attempts Christoph Lameter
2005-12-08 20:52 ` Andi Kleen [this message]
2005-12-08 21:08 ` Christoph Lameter
2005-12-08 21:08 ` Christoph Lameter
2005-12-08 21:10 ` Andi Kleen
2005-12-08 21:08 ` [PATCH 1/3] Zone reclaim V3: main patch Andi Kleen
2005-12-08 21:23 ` Christoph Lameter
2005-12-08 22:51 ` Andi Kleen
2005-12-08 23:19 ` Christoph Lameter
2005-12-08 23:28 ` [discuss] " Andi Kleen
2005-12-08 23:35 ` Christoph Lameter
2005-12-08 23:40 ` Andi Kleen
2005-12-09 0:10 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051208205241.GR11190@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steiner@sgi.com \
--cc=wfg@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox