[PATCH] drivers/input/misc: Added Acer TravelMate 240 support to the wistron button interface

[PATCH] drivers/input/misc: Added Acer TravelMate 240 support to the wistron button interface

[Ashutosh Naik]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

This patch adds Acer TravelMate 240 support to the wistron button
interface. This means that the buttons on top of the
keyboard(including ones for Wifi and Bluetooth),  which hitherto did
not work, work now. I have tested it on my laptop and it seems to work
great.

Signed-off-by: Ashutosh Naik <ashutosh.naik@gmail.com>

[-- Attachment #2: acer_patch.txt --]
[-- Type: text/plain, Size: 1173 bytes --]

diff -Naurp linux-2.6.15-rc5-vanilla/drivers/input/misc/wistron_btns.c linux-2.6.15-rc5/drivers/input/misc/wistron_btns.c
--- linux-2.6.15-rc5-vanilla/drivers/input/misc/wistron_btns.c	2005-12-10 23:40:19.000000000 +0530
+++ linux-2.6.15-rc5/drivers/input/misc/wistron_btns.c	2005-12-10 23:42:00.000000000 +0530
@@ -296,6 +296,16 @@ static struct key_entry keymap_acer_aspi
 	{ KE_END, 0 }
 };
 
+static struct key_entry keymap_acer_travelmate_240[] = {
+	{ KE_KEY, 0x31, KEY_MAIL },
+	{ KE_KEY, 0x36, KEY_WWW },
+	{ KE_KEY, 0x11, KEY_PROG1 },
+	{ KE_KEY, 0x12, KEY_PROG2 },
+	{ KE_BLUETOOTH, 0x44, 0 },
+	{ KE_WIFI, 0x30, 0 },
+	{ KE_END, 0 }
+};
+
 /*
  * If your machine is not here (which is currently rather likely), please send
  * a list of buttons and their key codes (reported when loading this module
@@ -320,6 +330,15 @@ static struct dmi_system_id dmi_ids[] = 
 		},
 		.driver_data = keymap_acer_aspire_1500
 	},
+	{
+		.callback = dmi_matched,
+		.ident = "Acer TravelMate 240",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 240"),
+		},
+		.driver_data = keymap_acer_travelmate_240
+	},
 	{ 0, }
 };
 

Re: [PATCH] drivers/input/misc: Added Acer TravelMate 240 support to the wistron button interface

[Miloslav Trmac]

Ashutosh Naik wrote:
> This patch adds Acer TravelMate 240 support to the wistron button
> interface. This means that the buttons on top of the
> keyboard(including ones for Wifi and Bluetooth),  which hitherto did
> not work, work now. I have tested it on my laptop and it seems to work
> great.
Please check that the ACPI "button.ko" driver can't provide the
functionality; newer laptops apparently work better with that driver
(http://lkml.org/lkml/2005/12/2/61).

Thanks,
	Mirek

Re: [PATCH] drivers/input/misc: Added Acer TravelMate 240 support to the wistron button interface

[Ashutosh Naik]

On 12/11/05, Miloslav Trmac <mitr@volny.cz> wrote:

> > This patch adds Acer TravelMate 240 support to the wistron button
> > interface. This means that the buttons on top of the
> > keyboard(including ones for Wifi and Bluetooth),  which hitherto did
> > not work, work now. I have tested it on my laptop and it seems to work
> > great.
> Please check that the ACPI "button.ko" driver can't provide the
> functionality; newer laptops apparently work better with that driver
> (http://lkml.org/lkml/2005/12/2/61).

The Acer TravelMate 240 laptop supports ACPI, but the ACPI does not
support hotkeys. Hence hotkeys just would not work without this
module.

Regards
Ashutosh

Re: [PATCH] drivers/input/misc: Added Acer TravelMate 240 support to the wistron button interface

[Dmitry Torokhov]

On Sunday 11 December 2005 00:48, Ashutosh Naik wrote:
> On 12/11/05, Miloslav Trmac <mitr@volny.cz> wrote:
> 
> > > This patch adds Acer TravelMate 240 support to the wistron button
> > > interface. This means that the buttons on top of the
> > > keyboard(including ones for Wifi and Bluetooth),  which hitherto did
> > > not work, work now. I have tested it on my laptop and it seems to work
> > > great.
> > Please check that the ACPI "button.ko" driver can't provide the
> > functionality; newer laptops apparently work better with that driver
> > (http://lkml.org/lkml/2005/12/2/61).
> 
> The Acer TravelMate 240 laptop supports ACPI, but the ACPI does not
> support hotkeys. Hence hotkeys just would not work without this
> module.
>

I added this to my input tree.

-- 
Dmitry

Re: [PATCH] drivers/input/misc: Added Acer TravelMate 240 support to the wistron button interface

[Miloslav Trmac]

Ashutosh Naik wrote:
> This patch adds Acer TravelMate 240 support to the wistron button
> interface. This means that the buttons on top of the
> keyboard(including ones for Wifi and Bluetooth),  which hitherto did
> not work, work now. I have tested it on my laptop and it seems to work
> great.
> 
> Signed-off-by: Ashutosh Naik <ashutosh.naik@gmail.com>
Signed-off-by: Miloslav Trmac <mitr@volny.cz>