From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Jean Delvare <khali@linux-fr.org>, Greg KH <greg@kroah.com>,
LKML <linux-kernel@vger.kernel.org>,
Alessandro Zummo <alessandro.zummo@towertech.it>
Subject: Re: More platform driver questions
Date: Sun, 11 Dec 2005 19:41:56 -0500 [thread overview]
Message-ID: <200512111941.57216.dtor_core@ameritech.net> (raw)
In-Reply-To: <20051211221034.GE22537@flint.arm.linux.org.uk>
On Sunday 11 December 2005 17:10, Russell King wrote:
> > 2* Is it OK to tag platform_driver.probe and .remove __devinit and
> > __devexit, respectively?
>
> Yes, provided that you only have one platform device which is never
> removed independently of being a module or hotplug.
It just occured to me - every platform driver should rely on ->probe()
and ->remove() because now we have "bind" and "unbind" attributes and
there are talks about providing a method to disable automatic binding
of drivers across bus or even entire system. So even without hotplug
there possibility that user might want to disable device by unbinding
driver.
I think it pretty safe to mark them __devinit and __devexit because they
become noops if CONFIG_HOTPLUG is set. There is trouble with "bind" and
"unbind" sysfs attributes when CONFIG_HOTPLUG=N but Greg promised to fix
that.
--
Dmitry
next prev parent reply other threads:[~2005-12-12 0:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-11 21:00 More platform driver questions Jean Delvare
2005-12-11 22:10 ` Russell King
2005-12-12 0:41 ` Dmitry Torokhov [this message]
2005-12-13 7:17 ` Jean Delvare
2005-12-13 7:23 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200512111941.57216.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=alessandro.zummo@towertech.it \
--cc=greg@kroah.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox