From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@osdl.org>,
adi@hexapodia.org, linux-kernel@vger.kernel.org
Subject: Re: swsusp performance problems in 2.6.15-rc3-mm1
Date: Mon, 12 Dec 2005 00:28:05 +0100 [thread overview]
Message-ID: <20051211232805.GC5982@elf.ucw.cz> (raw)
In-Reply-To: <200512111316.47153.rjw@sisk.pl>
Hi!
> > > Would that be ok if I made drop_pagecache() nonstatic and called it directly
> > > from swsusp?
> >
> > Sure, I'll updates the patch for that.
>
> Thanks a lot.
>
> > It changed a bit.. You'll need to run sys_sync() then drop_pagecache()
> > then drop_slab().
>
> I think it won't hurt if we do this unconditionally in swsusp_shrink_memory().
> Pavel, what do you think?
>
> The appended patch illustrates the way in which I think we can use this.
> I've tested it a little, but if someone feels like trying it, please
> do.
Not sure, do we really want to drop all the pagecache? We want to free
memory that is not going to be used soon after suspend, but I guess
pagecache can be quite "hot".
I'd certainly wait with this until code settles. And at least trying
if it helps or hurts...
Pavel
--
Thanks, Sharp!
next prev parent reply other threads:[~2005-12-11 23:28 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-05 8:19 swsusp performance problems in 2.6.15-rc3-mm1 Andy Isaacson
2005-12-05 12:17 ` Pavel Machek
2005-12-05 13:58 ` Nigel Cunningham
2005-12-05 17:29 ` Pavel Machek
2005-12-05 21:11 ` Nigel Cunningham
2005-12-05 23:34 ` Pavel Machek
2005-12-06 1:26 ` Nigel Cunningham
2005-12-06 1:52 ` Pavel Machek
2005-12-05 22:44 ` Rafael J. Wysocki
2005-12-06 0:01 ` Pavel Machek
2005-12-05 22:28 ` Rafael J. Wysocki
2005-12-06 1:07 ` Nigel Cunningham
2005-12-06 1:37 ` Pavel Machek
2005-12-06 1:47 ` Andy Isaacson
2005-12-06 1:56 ` IDE performance on notebooks [was Re: swsusp performance problems in 2.6.15-rc3-mm1] Pavel Machek
2005-12-06 6:23 ` Andy Isaacson
2005-12-06 11:56 ` Pavel Machek
2005-12-06 1:57 ` swsusp performance problems in 2.6.15-rc3-mm1 Nigel Cunningham
2005-12-06 3:50 ` Mark Lord
2005-12-06 15:03 ` Mark Lord
2005-12-06 2:02 ` Nigel Cunningham
2005-12-06 12:09 ` Pavel Machek
2005-12-06 1:36 ` Nigel Cunningham
2005-12-06 2:06 ` Andy Isaacson
2005-12-06 2:21 ` Nigel Cunningham
2005-12-06 14:22 ` Pavel Machek
2005-12-07 22:05 ` Nigel Cunningham
2005-12-07 22:23 ` Pavel Machek
2005-12-06 2:21 ` Nigel Cunningham
2005-12-06 12:18 ` Pavel Machek
2005-12-06 18:15 ` Andy Isaacson
2005-12-07 1:05 ` Rafael J. Wysocki
2005-12-07 1:10 ` Pavel Machek
2005-12-07 11:17 ` Rafael J. Wysocki
2005-12-07 11:30 ` Pavel Machek
2005-12-08 22:42 ` Rafael J. Wysocki
2005-12-08 22:50 ` Pavel Machek
2005-12-05 21:18 ` Rafael J. Wysocki
2005-12-05 23:55 ` swsusp: how much memory to free? [was Re: swsusp performance problems in 2.6.15-rc3-mm1] Pavel Machek
2005-12-07 11:53 ` Rafael J. Wysocki
2005-12-07 11:59 ` Pavel Machek
2005-12-07 12:16 ` Rafael J. Wysocki
2005-12-07 12:18 ` Pavel Machek
2005-12-05 23:05 ` swsusp performance problems in 2.6.15-rc3-mm1 Rafael J. Wysocki
2005-12-06 0:12 ` Andy Isaacson
2005-12-06 0:51 ` Pavel Machek
2005-12-10 22:21 ` Andrew Morton
2005-12-10 23:07 ` Rafael J. Wysocki
2005-12-10 23:33 ` Andrew Morton
2005-12-11 12:16 ` Rafael J. Wysocki
2005-12-11 23:28 ` Pavel Machek [this message]
2005-12-12 17:45 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051211232805.GC5982@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=adi@hexapodia.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox