Re: [PATCH] Cpuset: rcu optimization of page alloc hook

Nick Piggin
2005-12-12T09:39:08Z

Andrew Morton wrote:
> Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>

>>
>>Is it a good idea for all kmem_cache_t? If so, can we move
>>__read_mostly to the type definition?
>>
>
>
> Yes, I suppose that's worthwhile.
>
> We've been shuffling towards removing kmem_cache_t in favour of `struct
> kmem_cache', but this is an argument against doing that.
>
> If we can work out how:
>
> void foo()
> {
> kmem_cache_t *p;
> }
>
> That'll barf.
>

Mmm. And the structure within structure, which Eric points out. I assumed
without grepping that those were mostly confined to slab itself and would
be easy to special case, but it turns out networking makes some use of
them too.

--
SUSE Labs, Novell Inc.

Send instant messages to your online friends http://au.messenger.yahoo.com