Re: [PATCH] Cpuset: rcu optimization of page alloc hook

Eric Dumazet
2005-12-12T08:50:23Z

Paul Jackson a écrit :

> +
> +static kmem_cache_t *cpuset_cache;
> +

Hi Paul

Please do use __read_mostly for new kmem_cache :

static kmem_cache_t *cpuset_cache __read_mostly;

If not, the pointer can sit in the midle of a highly modified cache line, and
multiple CPUS will have memory cache misses to access the cpuset_cache, while
slab code/data layout itself is very NUMA/SMP friendly.

Eric