Re: [PATCH] Cpuset: rcu optimization of page alloc hook

Nick Piggin
2005-12-12T08:54:52Z

Eric Dumazet wrote:
> Paul Jackson a écrit :
>
>> +
>> +static kmem_cache_t *cpuset_cache;
>> +
>
>
> Hi Paul
>
> Please do use __read_mostly for new kmem_cache :
>
> static kmem_cache_t *cpuset_cache __read_mostly;
>
> If not, the pointer can sit in the midle of a highly modified cache
> line, and multiple CPUS will have memory cache misses to access the
> cpuset_cache, while slab code/data layout itself is very NUMA/SMP friendly.
>

Is it a good idea for all kmem_cache_t? If so, can we move
__read_mostly to the type definition?

--
SUSE Labs, Novell Inc.

Send instant messages to your online friends http://au.messenger.yahoo.com