From: Nathan Lynch <ntl@pobox.com>
To: Brian King <brking@us.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Andrew Morton <akpm@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>, Jens Axboe <axboe@suse.de>,
Linus Torvalds <torvalds@osdl.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: Memory corruption & SCSI in 2.6.15
Date: Mon, 12 Dec 2005 15:01:55 -0500 [thread overview]
Message-ID: <20051212200155.GC19599@localhost.localdomain> (raw)
In-Reply-To: <439DC9E4.6030508@us.ibm.com>
Brian King wrote:
> Benjamin Herrenschmidt wrote:
> >Hi !
> >
> >Current -git as of today (that is 2.6.15-rc5 + the batch of fixes Linus
> >pulled after his return) was dying in weird ways for me on POWER5. I had
> >the good idea to activate slab debugging, and I now see it detecting
> >slab corruption as soon as the IPR driver initializes.
>
> Please try the attached patch. There appears to be a double free going on
> in the scsi scan code. There is a direct call to scsi_free_queue and then
> the following put_device calls the release function, which also frees
> the queue.
Tested against 2.6.15-rc5, seems to fix it, thanks.
Nathan
prev parent reply other threads:[~2005-12-12 20:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-12 7:13 Memory corruption & SCSI in 2.6.15 Benjamin Herrenschmidt
2005-12-12 17:17 ` Linus Torvalds
2005-12-12 18:32 ` Nathan Lynch
2005-12-12 18:51 ` Jens Axboe
2005-12-12 20:33 ` Benjamin Herrenschmidt
2005-12-12 20:51 ` Linus Torvalds
2005-12-12 20:57 ` Benjamin Herrenschmidt
2005-12-13 0:11 ` Benjamin Herrenschmidt
2005-12-12 18:09 ` Jens Axboe
2005-12-12 19:05 ` Brian King
2005-12-12 19:55 ` Linus Torvalds
2005-12-12 20:13 ` James Bottomley
2005-12-12 20:01 ` Nathan Lynch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051212200155.GC19599@localhost.localdomain \
--to=ntl@pobox.com \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=benh@kernel.crashing.org \
--cc=brking@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=paulus@samba.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox