Re: [PATCH 3/3] sanitize building of fs/compat_ioctl.c

David S. Miller
2005-12-14T02:24:07Z

From: Andi Kleen <ak@suse.de>
Date: 14 Dec 2005 02:41:42 +0100

> "David S. Miller" <davem@davemloft.net> writes:
>
> > What do you really still need it for at this point?
>
> input needs it :/ Take a look at drivers/input/evdev.c:evdev_write_compat
...
> I have given in for now. Assuming the test is done on a flag that is only set
> by the system call entry path. But I still think it will result in
> a lot of ugly code. For for read/write it's hard to avoid because
> there are so many variants and we have too many message passing
> protocols now.

I suppose. We could also funnel down ->compat_{read,write}() and
so on down the call chain, but that would likely be even uglier.

I guess with is_compat_task() we can do the netlink and pfkeyv2 compat
stuff on ia64/x86_64. I don't look forward to reviewing a patch
implementing that, however :-/