From: Christoph Hellwig <hch@lst.de>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 5/6] move MS_NOATIME mirroring inside xfs
Date: Tue, 13 Dec 2005 18:56:55 +0100 [thread overview]
Message-ID: <20051213175655.GE17130@lst.de> (raw)
XFS propagates MS_NOATIME through two levels internally but doesn't
actually use it. Kill this dead code.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6.15-rc5/fs/xfs/linux-2.6/xfs_super.c
===================================================================
--- linux-2.6.15-rc5.orig/fs/xfs/linux-2.6/xfs_super.c 2005-12-12 18:51:18.000000000 +0100
+++ linux-2.6.15-rc5/fs/xfs/linux-2.6/xfs_super.c 2005-12-13 11:48:12.000000000 +0100
@@ -76,8 +76,6 @@
strncpy(args->fsname, sb->s_id, MAXNAMELEN);
/* Copy the already-parsed mount(2) flags we're interested in */
- if (sb->s_flags & MS_NOATIME)
- args->flags |= XFSMNT_NOATIME;
if (sb->s_flags & MS_DIRSYNC)
args->flags |= XFSMNT_DIRSYNC;
if (sb->s_flags & MS_SYNCHRONOUS)
Index: linux-2.6.15-rc5/fs/xfs/xfs_clnt.h
===================================================================
--- linux-2.6.15-rc5.orig/fs/xfs/xfs_clnt.h 2005-12-12 18:51:18.000000000 +0100
+++ linux-2.6.15-rc5/fs/xfs/xfs_clnt.h 2005-12-13 11:48:18.000000000 +0100
@@ -68,8 +68,6 @@
* enforcement */
#define XFSMNT_PQUOTAENF 0x00000040 /* IRIX project quota limit
* enforcement */
-#define XFSMNT_NOATIME 0x00000100 /* don't modify access
- * times on reads */
#define XFSMNT_NOALIGN 0x00000200 /* don't allocate at
* stripe boundaries*/
#define XFSMNT_RETERR 0x00000400 /* return error to user */
Index: linux-2.6.15-rc5/fs/xfs/xfs_mount.h
===================================================================
--- linux-2.6.15-rc5.orig/fs/xfs/xfs_mount.h 2005-12-12 18:51:18.000000000 +0100
+++ linux-2.6.15-rc5/fs/xfs/xfs_mount.h 2005-12-13 11:47:51.000000000 +0100
@@ -387,8 +387,6 @@
#define XFS_MOUNT_FS_SHUTDOWN (1ULL << 4) /* atomic stop of all filesystem
operations, typically for
disk errors in metadata */
-#define XFS_MOUNT_NOATIME (1ULL << 5) /* don't modify inode access
- times on reads */
#define XFS_MOUNT_RETERR (1ULL << 6) /* return alignment errors to
user */
#define XFS_MOUNT_NOALIGN (1ULL << 7) /* turn off stripe alignment
Index: linux-2.6.15-rc5/fs/xfs/xfs_vfsops.c
===================================================================
--- linux-2.6.15-rc5.orig/fs/xfs/xfs_vfsops.c 2005-12-12 18:51:18.000000000 +0100
+++ linux-2.6.15-rc5/fs/xfs/xfs_vfsops.c 2005-12-13 11:47:40.000000000 +0100
@@ -258,8 +258,6 @@
mp->m_inoadd = XFS_INO64_OFFSET;
}
#endif
- if (ap->flags & XFSMNT_NOATIME)
- mp->m_flags |= XFS_MOUNT_NOATIME;
if (ap->flags & XFSMNT_RETERR)
mp->m_flags |= XFS_MOUNT_RETERR;
if (ap->flags & XFSMNT_NOALIGN)
@@ -654,11 +652,6 @@
xfs_mount_t *mp = XFS_BHVTOM(bdp);
int error;
- if (args->flags & XFSMNT_NOATIME)
- mp->m_flags |= XFS_MOUNT_NOATIME;
- else
- mp->m_flags &= ~XFS_MOUNT_NOATIME;
-
if (args->flags & XFSMNT_BARRIER)
mp->m_flags |= XFS_MOUNT_BARRIER;
else
next reply other threads:[~2005-12-13 17:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-13 17:56 Christoph Hellwig [this message]
2005-12-13 18:02 ` [PATCH 5/6] move MS_NOATIME mirroring inside xfs Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051213175655.GE17130@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox