[patch 06/26] setkeys needs root

Greg KH
2005-12-13T08:31:13Z

[-- Attachment #1: setkeys-needs-root.patch --]
[-- Type: text/plain, Size: 1110 bytes --]

-stable review patch. If anyone has any objections, please let us know.

------------------
From: Daniel Drake <dsd@gentoo.org>

This patch combines commit 0b360adbdb54d5b98b78d57ba0916bc4b8871968 (make
setkeys root-only) and commit e3f17f0f6e98f58edb13cb38810d93e6d4808e68 (only
disallow setting by users)

Because people can play games reprogramming keys and leaving traps for the
next user of the console.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
drivers/char/vt_ioctl.c | 6 ++++++
1 file changed, 6 insertions(+)

--- linux-2.6.14.3.orig/drivers/char/vt_ioctl.c
+++ linux-2.6.14.3/drivers/char/vt_ioctl.c
@@ -80,6 +80,9 @@ do_kdsk_ioctl(int cmd, struct kbentry __
if (copy_from_user(&tmp, user_kbe, sizeof(struct kbentry)))
return -EFAULT;

+ if (!capable(CAP_SYS_TTY_CONFIG))
+ perm = 0;
+
switch (cmd) {
case KDGKBENT:
key_map = key_maps[s];
@@ -192,6 +195,9 @@ do_kdgkb_ioctl(int cmd, struct kbsentry
int i, j, k;
int ret;

+ if (!capable(CAP_SYS_TTY_CONFIG))
+ perm = 0;
+
kbs = kmalloc(sizeof(*kbs), GFP_KERNEL);
if (!kbs) {
ret = -ENOMEM;

--