Re: 2.6.15-rc5-mm1 (x86_64-hpet-overflow.patch breaks resume from disk)

Rafael J. Wysocki
2005-12-09T13:09:37Z

On Friday, 9 December 2005 13:41, Jan Beulich wrote:
> >>> "Rafael J. Wysocki" <rjw@sisk.pl> 09.12.05 12:20:05 >>>
> >On Friday, 9 December 2005 10:15, Jan Beulich wrote:
> >> It's a possible way to address this, but I'd rather just set a flag
> >> indicating that the last-whatever values should not be considered
> (to
> >> get into a state just like after initial boot). Jan
> >
> >OK, but what is the interrupt handler supposed to do if the
> >vxtime.last* values are invalid? I guess assume delta = 0?
>
> As I said, the state should be (re)set to whatever is in effect at
> boot.
>
> >BTW, in the interrupt handler there is:
> >
> > __asm__("mulq %1\n\t"
> > "shrdq $32, %%rdx, %0"
> > : "+a" (delta)
> > : "rm" (vxtime.tsc_quot)
> > : "rdx");
> >
> >Is the "+a" a typo?
>
> Why would you think so?

Well, "=" is usually used in that context and "+", "=" are on the same key. ;-)

Rafael

--
Beer is proof that God loves us and wants us to be happy - Benjamin Franklin