From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] per-mount noatime and nodiratime
Date: Tue, 13 Dec 2005 23:39:28 +0100 [thread overview]
Message-ID: <20051213223928.GA22373@lst.de> (raw)
In-Reply-To: <20051213143638.120ee601.akpm@osdl.org>
On Tue, Dec 13, 2005 at 02:36:38PM -0800, Andrew Morton wrote:
> Where'd this hunk come from?
>
> > Index: linux-2.6.15-rc5/fs/super.c
> > ===================================================================
> > --- linux-2.6.15-rc5.orig/fs/super.c 2005-12-13 11:27:14.000000000 +0100
> > +++ linux-2.6.15-rc5/fs/super.c 2005-12-13 12:06:00.000000000 +0100
> > @@ -830,9 +830,9 @@
> > mnt->mnt_parent = mnt;
> >
> > if (type->fs_flags & FS_NOATIME)
> > - sb->s_flags |= MS_NOATIME;
> > + mnt->mnt_flags |= MNT_NOATIME;
> > if (type->fs_flags & FS_NODIRATIME)
> > - sb->s_flags |= MS_NODIRATIME;
> > + mnt->mnt_flags |= MNT_NODIRATIME;
> >
> > up_write(&sb->s_umount);
> > free_secdata(secdata);
>
> I just dropped it, but it's a worry...
This is totally intentional. The FS_* flags were introduced in the
previous patch to mark filesystems that always are NOATIME/NODIRATIME,
and with this patch we need to set them in the vfsmount instead of the
superblock.
next prev parent reply other threads:[~2005-12-13 22:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-13 17:56 [PATCH 6/6] per-mount noatime and nodiratime Christoph Hellwig
2005-12-13 22:36 ` Andrew Morton
2005-12-13 22:39 ` Christoph Hellwig [this message]
2005-12-13 23:21 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051213223928.GA22373@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox