The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Jordan Crouse" <jordan.crouse@amd.com>
To: gardner.ben@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i386: GPIO driver for AMD CS5535/CS5536
Date: Tue, 13 Dec 2005 16:10:15 -0700	[thread overview]
Message-ID: <20051213231015.GB8896@cosmic.amd.com> (raw)

> A simple driver for the CS5535 and CS5536 that allows a user-space
> program to manipulate GPIO pins.
> The CS5535/CS5536 chips are Geode processor companion devices.

> Signed-off-by: Ben Gardner <bgardner <at> wabtec.com>

This all looks excellent to me.  Just FYI - If you want to get rid of the
rdmsr and just use the PCI header, you can also get the IO base of the 
GPIO registers from BAR1 of the DIVIL device.   Not a big deal,
but some people like to stay away from MSR accesses if they can avoid it.

Thanks for your hard work - its good to see Geode users pop up in the
community! :)

Jordan
-- 
Jordan Crouse
Senior Linux Engineer
AMD - Personal Connectivity Solutions Group
<www.amd.com/embeddedprocessors>


             reply	other threads:[~2005-12-13 23:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-13 23:10 Jordan Crouse [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-12-13 17:05 [PATCH] i386: GPIO driver for AMD CS5535/CS5536 Ben Gardner
2005-12-13 22:24 ` Andrew Morton
2005-12-13 22:57   ` Ben Gardner
2005-12-13 23:27     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051213231015.GB8896@cosmic.amd.com \
    --to=jordan.crouse@amd.com \
    --cc=gardner.ben@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox