* Re: [PATCH] skge: get rid of warning on race [not found] <200512130559.jBD5xUjf015319@hera.kernel.org> @ 2005-12-13 14:50 ` Olaf Hering 2005-12-13 15:45 ` Stephen Hemminger 2005-12-14 5:37 ` Dave Jones 1 sibling, 1 reply; 4+ messages in thread From: Olaf Hering @ 2005-12-13 14:50 UTC (permalink / raw) To: Linux Kernel Mailing List, Stephen Hemminger, Jeff Garzik On Mon, Dec 12, Linux Kernel Mailing List wrote: > tree 987cfbd2134b82bea55c55fa17bd70d29df70458 > parent 0e670506668a43e1355b8f10c33d081a676bd521 > author Stephen Hemminger <shemminger@osdl.org> Wed, 07 Dec 2005 07:01:49 -0800 > committer Jeff Garzik <jgarzik@pobox.com> Tue, 13 Dec 2005 09:33:03 -0500 > > [PATCH] skge: get rid of warning on race > drivers/net/skge.c | 10 ++++++---- > - netif_stop_queue(dev); > - spin_unlock_irqrestore(&skge->tx_lock, flags); > + if (!netif_stopped(dev)) { > + netif_stop_queue(dev); Current Linus tree does not compile: drivers/net/skge.c:2283: error: implicit declaration of function 'netif_stopped' -- short story of a lazy sysadmin: alias appserv=wotan ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] skge: get rid of warning on race 2005-12-13 14:50 ` [PATCH] skge: get rid of warning on race Olaf Hering @ 2005-12-13 15:45 ` Stephen Hemminger 0 siblings, 0 replies; 4+ messages in thread From: Stephen Hemminger @ 2005-12-13 15:45 UTC (permalink / raw) To: Olaf Hering; +Cc: Linux Kernel Mailing List, Jeff Garzik On Tue, 13 Dec 2005 15:50:54 +0100 Olaf Hering <olh@suse.de> wrote: > On Mon, Dec 12, Linux Kernel Mailing List wrote: > > > tree 987cfbd2134b82bea55c55fa17bd70d29df70458 > > parent 0e670506668a43e1355b8f10c33d081a676bd521 > > author Stephen Hemminger <shemminger@osdl.org> Wed, 07 Dec 2005 07:01:49 -0800 > > committer Jeff Garzik <jgarzik@pobox.com> Tue, 13 Dec 2005 09:33:03 -0500 > > > > [PATCH] skge: get rid of warning on race > > > drivers/net/skge.c | 10 ++++++---- > > > - netif_stop_queue(dev); > > - spin_unlock_irqrestore(&skge->tx_lock, flags); > > + if (!netif_stopped(dev)) { > > + netif_stop_queue(dev); > > Current Linus tree does not compile: > > drivers/net/skge.c:2283: error: implicit declaration of function 'netif_stopped' Should have been netif_queue_stopped.. Index: skge-2.6/drivers/net/skge.c =================================================================== --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -2280,7 +2280,7 @@ static int skge_xmit_frame(struct sk_buf } if (unlikely(skge->tx_avail < skb_shinfo(skb)->nr_frags +1)) { - if (!netif_stopped(dev)) { + if (!netif_queue_stopped(dev)) { netif_stop_queue(dev); printk(KERN_WARNING PFX "%s: ring full when queue awake!\n", ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] skge: get rid of warning on race [not found] <200512130559.jBD5xUjf015319@hera.kernel.org> 2005-12-13 14:50 ` [PATCH] skge: get rid of warning on race Olaf Hering @ 2005-12-14 5:37 ` Dave Jones 2005-12-14 6:47 ` David S. Miller 1 sibling, 1 reply; 4+ messages in thread From: Dave Jones @ 2005-12-14 5:37 UTC (permalink / raw) To: Linux Kernel Mailing List; +Cc: Stephen Hemminger, Jeff Garzik, netdev On Mon, Dec 12, 2005 at 09:59:30PM -0800, Linux Kernel wrote: > tree 987cfbd2134b82bea55c55fa17bd70d29df70458 > parent 0e670506668a43e1355b8f10c33d081a676bd521 > author Stephen Hemminger <shemminger@osdl.org> Wed, 07 Dec 2005 07:01:49 -0800 > committer Jeff Garzik <jgarzik@pobox.com> Tue, 13 Dec 2005 09:33:03 -0500 > > [PATCH] skge: get rid of warning on race > > Get rid of warning in case of race with ring full and lockless > tx on the skge driver. It is possible to be in the transmit > routine with no available slots and already stopped. > > Signed-off-by: Stephen Hemminger <shemminger@osdl.org> > Signed-off-by: Jeff Garzik <jgarzik@pobox.com> You've traded a warning for something more serious :) now I get... drivers/net/skge.ko needs unknown symbol netif_stopped Dave ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] skge: get rid of warning on race 2005-12-14 5:37 ` Dave Jones @ 2005-12-14 6:47 ` David S. Miller 0 siblings, 0 replies; 4+ messages in thread From: David S. Miller @ 2005-12-14 6:47 UTC (permalink / raw) To: davej; +Cc: linux-kernel, shemminger, jgarzik, netdev From: Dave Jones <davej@redhat.com> Date: Wed, 14 Dec 2005 00:37:08 -0500 > drivers/net/skge.ko needs unknown symbol netif_stopped it's a typo, it should be netif_queue_stopped(). :-/ ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-12-14 6:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200512130559.jBD5xUjf015319@hera.kernel.org>
2005-12-13 14:50 ` [PATCH] skge: get rid of warning on race Olaf Hering
2005-12-13 15:45 ` Stephen Hemminger
2005-12-14 5:37 ` Dave Jones
2005-12-14 6:47 ` David S. Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox