From: Matthew Wilcox <matthew@wil.cx>
To: Martin Peschke <mp3@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, linux-scsi@vger.kernel.org
Subject: Re: [patch 6/6] statistics infrastructure - exploitation: zfcp
Date: Wed, 14 Dec 2005 09:24:37 -0700 [thread overview]
Message-ID: <20051214162437.GW9286@parisc-linux.org> (raw)
In-Reply-To: <43A044E6.7060403@de.ibm.com>
On Wed, Dec 14, 2005 at 05:14:30PM +0100, Martin Peschke wrote:
> if (device_register(&unit->sysfs_device)) {
> + zfcp_unit_statistic_unregister(unit);
> kfree(unit);
> return NULL;
> }
>
> if (zfcp_sysfs_unit_create_files(&unit->sysfs_device)) {
> + zfcp_unit_statistic_unregister(unit);
> device_unregister(&unit->sysfs_device);
> return NULL;
> }
Unrelated, but doesn't that error path forget to release unit?
next prev parent reply other threads:[~2005-12-14 16:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-14 16:14 [patch 6/6] statistics infrastructure - exploitation: zfcp Martin Peschke
2005-12-14 16:24 ` Matthew Wilcox [this message]
2005-12-14 16:55 ` Martin Peschke
2005-12-14 17:17 ` Heiko Carstens
2005-12-14 16:59 ` Christoph Hellwig
2005-12-15 3:54 ` Martin Peschke
2005-12-15 7:37 ` Arjan van de Ven
2005-12-15 11:23 ` Martin Peschke
2005-12-15 11:46 ` Arjan van de Ven
2005-12-15 14:38 ` Martin Peschke
-- strict thread matches above, loose matches on Subject: below --
2005-12-15 15:27 James.Smart
2005-12-15 17:47 ` Martin Peschke
2006-05-19 16:14 [Patch " Martin Peschke
2006-05-24 12:35 Martin Peschke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051214162437.GW9286@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mp3@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox