From: Paul Jackson <pj@sgi.com>
To: "Zhang, Yanmin" <yanmin.zhang@intel.com>
Cc: linux-kernel@vger.kernel.org, venkatesh.pallipadi@intel.com
Subject: Re: [PATCH 1/2] Export cpu info by sysfs
Date: Wed, 14 Dec 2005 18:03:10 -0800 [thread overview]
Message-ID: <20051214180310.b5b9c15f.pj@sgi.com> (raw)
In-Reply-To: <8126E4F969BA254AB43EA03C59F44E840431C3E2@pdsmsx404>
Yanmin wrote:
> cpumask_scnprintf(buf, NR_CPUS+1, cpu_core_map[cpu]);
Paul wrote:
> The 2nd arg, "NR_CPUS+1", is wrong. It should be the length
> of the buffer
Yanmin replied:
> In theory, it's a problem which doesn't exist in fact.
Aha - you are right. My confusion was that I had forgotten
the format used by cpumask_scnprintf, and thought it was one
of the other formats, not a hex mask, that could overflow
NR_CPUS+1 characters of output. Please nevermind my confusion.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
next prev parent reply other threads:[~2005-12-15 2:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-15 1:33 [PATCH 1/2] Export cpu info by sysfs Zhang, Yanmin
2005-12-15 2:03 ` Paul Jackson [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-12-14 3:30 Zhang, Yanmin
2005-12-14 4:14 ` Nathan Lynch
2005-12-14 10:12 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051214180310.b5b9c15f.pj@sgi.com \
--to=pj@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
--cc=yanmin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox