[PATCH] slab gcc fix

[PATCH] slab gcc fix

[Christoph Lameter]

Since we no longer support 2.95, we can get rid of this ugly thing.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

Index: linux-2.6.15-rc5-mm2/mm/slab.c
===================================================================
--- linux-2.6.15-rc5-mm2.orig/mm/slab.c	2005-12-13 13:18:48.000000000 -0800
+++ linux-2.6.15-rc5-mm2/mm/slab.c	2005-12-13 13:19:11.000000000 -0800
@@ -265,11 +265,10 @@ struct array_cache {
 	unsigned int batchcount;
 	unsigned int touched;
 	spinlock_t lock;
-	void *entry[0];		/*
+	void *entry[];		/*
 				 * Must have this definition in here for the proper
 				 * alignment of array_cache. Also simplifies accessing
 				 * the entries.
-				 * [0] is for gcc 2.95. It should really be [].
 				 */
 };
 

Re: [PATCH] slab gcc fix

[Andrew Morton]

Christoph Lameter <clameter@engr.sgi.com> wrote:
>
> Since we no longer support 2.95, we can get rid of this ugly thing.
> 
>  Signed-off-by: Christoph Lameter <clameter@sgi.com>
> 
>  Index: linux-2.6.15-rc5-mm2/mm/slab.c
>  ===================================================================
>  --- linux-2.6.15-rc5-mm2.orig/mm/slab.c	2005-12-13 13:18:48.000000000 -0800
>  +++ linux-2.6.15-rc5-mm2/mm/slab.c	2005-12-13 13:19:11.000000000 -0800
>  @@ -265,11 +265,10 @@ struct array_cache {
>   	unsigned int batchcount;
>   	unsigned int touched;
>   	spinlock_t lock;
>  -	void *entry[0];		/*
>  +	void *entry[];		/*

There are hundreds of instances of this under include/.  I think we just
live with it.

Plus the gcc-2.95 abandonment is tentative for now, so let's not go nuts. 
It's conceivable that someone has a good reason for needing it retained - we'll
see.

Re: [PATCH] slab gcc fix

[Kurt Wall]

On Tuesday 13 December 2005 04:39 pm, Andrew Morton wrote:
> Christoph Lameter <clameter@engr.sgi.com> wrote:
> > Since we no longer support 2.95, we can get rid of this ugly thing.
> >
> >  Signed-off-by: Christoph Lameter <clameter@sgi.com>
> >
> >  Index: linux-2.6.15-rc5-mm2/mm/slab.c
> >  ===================================================================
> >  --- linux-2.6.15-rc5-mm2.orig/mm/slab.c 2005-12-13 13:18:48.000000000
> > -0800 +++ linux-2.6.15-rc5-mm2/mm/slab.c 2005-12-13 13:19:11.000000000
> > -0800 @@ -265,11 +265,10 @@ struct array_cache {
> >    unsigned int batchcount;
> >    unsigned int touched;
> >    spinlock_t lock;
> >  - void *entry[0];  /*
> >  + void *entry[];  /*
>
> There are hundreds of instances of this under include/.  I think we just
> live with it.

Good kernel janitors task, perhaps?

Kurt
-- 
Loud burping while walking around the airport is prohibited in
Halstead, Kansas.