* [PATCH] slab gcc fix
@ 2005-12-13 21:29 Christoph Lameter
2005-12-13 21:39 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Lameter @ 2005-12-13 21:29 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel
Since we no longer support 2.95, we can get rid of this ugly thing.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Index: linux-2.6.15-rc5-mm2/mm/slab.c
===================================================================
--- linux-2.6.15-rc5-mm2.orig/mm/slab.c 2005-12-13 13:18:48.000000000 -0800
+++ linux-2.6.15-rc5-mm2/mm/slab.c 2005-12-13 13:19:11.000000000 -0800
@@ -265,11 +265,10 @@ struct array_cache {
unsigned int batchcount;
unsigned int touched;
spinlock_t lock;
- void *entry[0]; /*
+ void *entry[]; /*
* Must have this definition in here for the proper
* alignment of array_cache. Also simplifies accessing
* the entries.
- * [0] is for gcc 2.95. It should really be [].
*/
};
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] slab gcc fix
2005-12-13 21:29 [PATCH] slab gcc fix Christoph Lameter
@ 2005-12-13 21:39 ` Andrew Morton
2005-12-15 4:35 ` Kurt Wall
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2005-12-13 21:39 UTC (permalink / raw)
To: Christoph Lameter; +Cc: linux-kernel
Christoph Lameter <clameter@engr.sgi.com> wrote:
>
> Since we no longer support 2.95, we can get rid of this ugly thing.
>
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
>
> Index: linux-2.6.15-rc5-mm2/mm/slab.c
> ===================================================================
> --- linux-2.6.15-rc5-mm2.orig/mm/slab.c 2005-12-13 13:18:48.000000000 -0800
> +++ linux-2.6.15-rc5-mm2/mm/slab.c 2005-12-13 13:19:11.000000000 -0800
> @@ -265,11 +265,10 @@ struct array_cache {
> unsigned int batchcount;
> unsigned int touched;
> spinlock_t lock;
> - void *entry[0]; /*
> + void *entry[]; /*
There are hundreds of instances of this under include/. I think we just
live with it.
Plus the gcc-2.95 abandonment is tentative for now, so let's not go nuts.
It's conceivable that someone has a good reason for needing it retained - we'll
see.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] slab gcc fix
2005-12-13 21:39 ` Andrew Morton
@ 2005-12-15 4:35 ` Kurt Wall
0 siblings, 0 replies; 3+ messages in thread
From: Kurt Wall @ 2005-12-15 4:35 UTC (permalink / raw)
To: Andrew Morton; +Cc: Christoph Lameter, linux-kernel
On Tuesday 13 December 2005 04:39 pm, Andrew Morton wrote:
> Christoph Lameter <clameter@engr.sgi.com> wrote:
> > Since we no longer support 2.95, we can get rid of this ugly thing.
> >
> > Signed-off-by: Christoph Lameter <clameter@sgi.com>
> >
> > Index: linux-2.6.15-rc5-mm2/mm/slab.c
> > ===================================================================
> > --- linux-2.6.15-rc5-mm2.orig/mm/slab.c 2005-12-13 13:18:48.000000000
> > -0800 +++ linux-2.6.15-rc5-mm2/mm/slab.c 2005-12-13 13:19:11.000000000
> > -0800 @@ -265,11 +265,10 @@ struct array_cache {
> > unsigned int batchcount;
> > unsigned int touched;
> > spinlock_t lock;
> > - void *entry[0]; /*
> > + void *entry[]; /*
>
> There are hundreds of instances of this under include/. I think we just
> live with it.
Good kernel janitors task, perhaps?
Kurt
--
Loud burping while walking around the airport is prohibited in
Halstead, Kansas.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-12-15 4:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-13 21:29 [PATCH] slab gcc fix Christoph Lameter
2005-12-13 21:39 ` Andrew Morton
2005-12-15 4:35 ` Kurt Wall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox