public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: miles.lane@gmail.com, linux-kernel@vger.kernel.org,
	greg@kroah.com, linux@dominikbrodowski.net,
	alan@lxorguk.ukuu.org.uk, nickpiggin@yahoo.com.au
Subject: Re: 2.6.15-rc5-mm3 -- BUG: using smp_processor_id() in preemptible [00000001] code: swapper/1
Date: Thu, 15 Dec 2005 01:00:38 -0800	[thread overview]
Message-ID: <20051215010038.12ca576f.akpm@osdl.org> (raw)
In-Reply-To: <20051215004028.0bf9791f.akpm@osdl.org>

Andrew Morton <akpm@osdl.org> wrote:
>
> > Here's the BUG output:
>  > 
>  > [4294671.538000] Freeing unused kernel memory: 220k freed
>  > [4294671.538000] BUG: using smp_processor_id() in preemptible
>  > [00000001] code: swapper/1
>  > [4294671.539000] caller is mod_page_state_offset+0x12/0x28
>  > [4294671.539000]  [<c1003723>] dump_stack+0x16/0x1a
>  > [4294671.539000]  [<c110c1eb>] debug_smp_processor_id+0x77/0x90
>  > [4294671.539000]  [<c10413d3>] mod_page_state_offset+0x12/0x28

This'll plug the above.

Nick, please turn on the nice debugging options in future?


diff -puN mm/page_alloc.c~mm-page_state-opt-fix mm/page_alloc.c
--- devel/mm/page_alloc.c~mm-page_state-opt-fix	2005-12-15 00:50:56.000000000 -0800
+++ devel-akpm/mm/page_alloc.c	2005-12-15 00:51:07.000000000 -0800
@@ -1389,8 +1389,8 @@ void mod_page_state_offset(unsigned long
 	unsigned long flags;
 	void *ptr;
 
-	ptr = &__get_cpu_var(page_states);
 	local_irq_save(flags);
+	ptr = &__get_cpu_var(page_states);
 	*(unsigned long *)(ptr + offset) += delta;
 	local_irq_restore(flags);
 }
_


  reply	other threads:[~2005-12-15  9:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-15  8:35 2.6.15-rc5-mm3 -- BUG: using smp_processor_id() in preemptible [00000001] code: swapper/1 Miles Lane
2005-12-15  8:40 ` Andrew Morton
2005-12-15  9:00   ` Andrew Morton [this message]
2005-12-15 18:48     ` Dave Jones
2005-12-15  9:06   ` Nick Piggin
2005-12-15 18:20   ` 2.6.15-rc5-mm3 -- bus may be hidden warning Dominik Brodowski
2005-12-15  8:40 ` 2.6.15-rc5-mm3 -- BUG: using smp_processor_id() in preemptible [00000001] code: swapper/1 Miles Lane
2005-12-15 12:24 ` Alan Cox
2005-12-15 16:33   ` Michal Piotrowski
2005-12-17 20:33 ` Miles Lane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051215010038.12ca576f.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.net \
    --cc=miles.lane@gmail.com \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox