From: Christoph Hellwig <hch@infradead.org>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Al Viro <viro@ftp.linux.org.uk>,
Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org
Subject: Re: [PATCH 1/3] m68k: compile fix - hardirq checks were in wrong place
Date: Thu, 15 Dec 2005 12:22:53 +0000 [thread overview]
Message-ID: <20051215122252.GA23407@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0512151252110.1605@scrub.home>
> You separate the definition from the check, now you push the
> responsibility to get the order right to the header users.
> Sorry, but I prefer to fix the header dependencies than scatter things
> which belong together over multiple files.
For 2.6.16 I'll submit a patch to merge asm/irq.h and asm/hardirq.h.
Until then this is the much better fix because it doesn't require
pointless include reordering all over the tree.
next prev parent reply other threads:[~2005-12-15 12:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-15 8:54 [PATCH 1/3] m68k: compile fix - hardirq checks were in wrong place Al Viro
2005-12-15 11:58 ` Roman Zippel
2005-12-15 12:22 ` Christoph Hellwig [this message]
2005-12-15 12:33 ` Roman Zippel
2005-12-15 16:47 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051215122252.GA23407@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox