Re: [RFC] IRQ type flags

[Russell King <rmk+lkml@arm.linux.org.uk>]

On Tue, Dec 13, 2005 at 08:49:50AM -0600, Kumar Gala wrote:
> >+ * These correspond with the SA_TRIGGER_* defines, and therefore the
> >+ * IRQRESOURCE_IRQ_* defines.
> 
> comment nit.  Should be IORESOURCE_IRQ_* not IRQRESOURCE_IRQ_*

Added, thanks.

> >+/*
> >+ * As above, these correspond to the IORESOURCE_IRQ_* defines in
> >+ * linux/ioport.h to select the interrupt line behaviour.  When
> >+ * requesting an interrupt without specifying a SA_TRIGGER, the
> >+ * setting should be assumed to be "as already configured", which
> >+ * may be as per machine or firmware initialisation.
> >+ */
> 
> Do you mind expand the comment to convey that LOW/HIGH are related to  
> level sensitive interrupts and FALLING/RISING are for edge.  This is  
> different naming that I'm used to with PowerPC and it can get a  
> little confusing.

Also added.  Thanks.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core