From: Al Viro <viro@ftp.linux.org.uk>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org
Subject: Re: [PATCH 1/3] m68k: compile fix - hardirq checks were in wrong place
Date: Thu, 15 Dec 2005 16:47:36 +0000 [thread overview]
Message-ID: <20051215164736.GX27946@ftp.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.61.0512151252110.1605@scrub.home>
On Thu, Dec 15, 2005 at 12:58:12PM +0100, Roman Zippel wrote:
> You separate the definition from the check, now you push the
> responsibility to get the order right to the header users.
There are two definitions, one in old place, another in new one. You
need both seen before the check. On m68k hardirq.h doesn't pull irq.h;
irq.h, OTOH, *does* pull hardirq.h via linux/interrupt.h -> linux/hardirq.h ->
asm/hardirq.h. IOW, it's less responsibility, not more.
Moreover, new variant works; old one doesn't. Both are brittle, but the
old one is flat-out _broken_. As in, new one works with the actual
includes in the tree with no extra changes, old one breaks on a number
of existing files in the tree.
How the hell does that push responsibility to header users?
prev parent reply other threads:[~2005-12-15 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-15 8:54 [PATCH 1/3] m68k: compile fix - hardirq checks were in wrong place Al Viro
2005-12-15 11:58 ` Roman Zippel
2005-12-15 12:22 ` Christoph Hellwig
2005-12-15 12:33 ` Roman Zippel
2005-12-15 16:47 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051215164736.GX27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox