From: Andy Isaacson <adi@hexapodia.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Pavel Machek <pavel@suse.cz>, Stefan Seyfried <seife@suse.de>,
LKML <linux-kernel@vger.kernel.org>,
akpm@osdl.org
Subject: Re: [RFC/RFT] swsusp: image size tunable (was: Re: [PATCH][mm] swsusp: limit image size)
Date: Thu, 15 Dec 2005 18:09:03 -0800 [thread overview]
Message-ID: <20051216020903.GB26568@hexapodia.org> (raw)
In-Reply-To: <200512102356.27271.rjw@sisk.pl>
On Sat, Dec 10, 2005 at 11:56:26PM +0100, Rafael J. Wysocki wrote:
> Update:
>
> A cleaner version with comments etc. follows.
>
> Documentation/power/interface.txt | 11 +++++++++++
> Documentation/power/swsusp.txt | 7 ++++++-
> kernel/power/disk.c | 20 ++++++++++++++++++++
> kernel/power/power.h | 7 ++-----
> kernel/power/swsusp.c | 10 +++++++++-
> 5 files changed, 48 insertions(+), 7 deletions(-)
I've been testing this as present in 2.6.15-rc5-mm2 and it works like a
champ. I am currently running with image_size=150, which seems to be a
nice balance between quick suspend and still having a reasonable working
set after resume.
I did have one concerning failure during an earlier test, though - I
have only 512MB of swap with 1.25GB RAM. Now obviously if there are
>500MB user pages, swsusp must fail; but I think I had a failure even
though there was only about 400MB user pages - some of it was swapped
out, and I had image_size=500, which resulted in an image that would not
fit into the available swap space.
It sucks to fail the suspend just because the chosen image size didn't
fit into the current state of the machine. Now obviously I need to
resize my swap partition to prevent this from happening, but it would
be nice if swsusp would automatically "try harder!" if appropriate.
I can reproduce this and collect more data if needed.
-andy
next prev parent reply other threads:[~2005-12-16 2:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-07 21:46 [PATCH][mm] swsusp: limit image size Rafael J. Wysocki
2005-12-07 21:52 ` Pavel Machek
2005-12-09 15:45 ` Stefan Seyfried
2005-12-09 15:48 ` Stefan Seyfried
2005-12-09 17:04 ` Rafael J. Wysocki
2005-12-09 18:30 ` Stefan Seyfried
2005-12-09 19:17 ` Pavel Machek
2005-12-09 22:08 ` Rafael J. Wysocki
2005-12-10 13:21 ` [RFC/RFT] swsusp: image size tunable (was: Re: [PATCH][mm] swsusp: limit image size) Rafael J. Wysocki
2005-12-10 16:06 ` Pavel Machek
2005-12-10 20:06 ` Rafael J. Wysocki
2005-12-10 22:56 ` Rafael J. Wysocki
2005-12-10 23:01 ` Pavel Machek
2005-12-16 2:09 ` Andy Isaacson [this message]
2005-12-16 10:16 ` Stefan Seyfried
2005-12-16 14:26 ` Christian Trefzer
2005-12-16 18:08 ` Rafael J. Wysocki
2005-12-16 19:29 ` Christian Trefzer
2005-12-16 21:09 ` Rafael J. Wysocki
2005-12-17 16:47 ` [RFC] swsusp: brainstorming on a freaked-out approach (was: Re: [RFC/RFT] swsusp: image size tunable) Christian Trefzer
2005-12-18 17:44 ` Pavel Machek
2005-12-18 18:24 ` [RFC] swsusp: brainstorming on a freaked-out approach Christian Trefzer
2005-12-10 22:59 ` [RFC/RFT] swsusp: image size tunable (was: Re: [PATCH][mm] swsusp: limit image size) Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051216020903.GB26568@hexapodia.org \
--to=adi@hexapodia.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=rjw@sisk.pl \
--cc=seife@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox